From: Masahiro Yamada <masahiroy@kernel.org>
To: Will McVicker <willmcvicker@google.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
"Cc: Android Kernel" <kernel-team@android.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH 1/1] kbuild: install the modules.order for external modules
Date: Sat, 18 Dec 2021 10:00:27 +0900 [thread overview]
Message-ID: <CAK7LNAT=U9xE5QTPThRTf3V=WEh3WmUh6w-89mm+APjnYp701Q@mail.gmail.com> (raw)
In-Reply-To: <20211215172349.388497-1-willmcvicker@google.com>
(Cc: Lucas De Marchi)
On Thu, Dec 16, 2021 at 2:23 AM Will McVicker <willmcvicker@google.com> wrote:
>
> Add support to install the modules.order file for external modules
> during module_install in order to retain the Makefile ordering
> of external modules. This helps reduce the extra steps necessary to
> properly order loading of external modules when there are multiple
> kernel modules compiled within a given KBUILD_EXTMOD directory.
>
> To handle compiling multiple external modules within the same
> INSTALL_MOD_DIR, kbuild will append a suffix to the installed
> modules.order file defined like so:
>
> echo ${KBUILD_EXTMOD} | sed 's:[./_]:_:g'
>
> Ex:
> KBUILD_EXTMOD=/mnt/a.b/c-d/my_driver results in:
> modules.order._mnt_a_b_c_d_my_driver
>
> The installed module.order.$(extmod_suffix) files can then be cat'd
> together to create a single modules.order file which would define the
> order to load all of the modules during boot.
So, the user must do this manually?
cat extra/modules.order._mnt_a_b_c_d_my_driver \
extra/modules.order._mnt_e_f_g_h_my_driver \
>> modules.order
This is so ugly, and incomplete.
I cc'ed the kmod maintainer, who may have
comments or better approach.
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
> scripts/Makefile.modinst | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index ff9b09e4cfca..2e2e31696fd6 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -24,6 +24,10 @@ suffix-$(CONFIG_MODULE_COMPRESS_XZ) := .xz
> suffix-$(CONFIG_MODULE_COMPRESS_ZSTD) := .zst
>
> modules := $(patsubst $(extmod_prefix)%, $(dst)/%$(suffix-y), $(modules))
> +ifneq ($(KBUILD_EXTMOD),)
> +extmod_suffix := $(subst /,_,$(subst .,_,$(subst -,_,$(KBUILD_EXTMOD))))
> +modules += $(dst)/modules.order.$(extmod_suffix)
> +endif
>
> __modinst: $(modules)
> @:
> @@ -82,6 +86,12 @@ $(dst)/%.ko: $(extmod_prefix)%.ko FORCE
> $(call cmd,strip)
> $(call cmd,sign)
>
> +ifneq ($(KBUILD_EXTMOD),)
> +$(dst)/modules.order.$(extmod_suffix): $(MODORDER) FORCE
> + $(call cmd,install)
> + @sed -i "s:^$(KBUILD_EXTMOD):$(INSTALL_MOD_DIR):g" $@
> +endif
> +
> else
>
> $(dst)/%.ko: FORCE
> --
> 2.34.1.173.g76aa8bc2d0-goog
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-12-18 1:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 17:23 [PATCH 1/1] kbuild: install the modules.order for external modules Will McVicker
2021-12-18 1:00 ` Masahiro Yamada [this message]
2021-12-20 18:13 ` Will McVicker
2022-01-11 20:14 ` Will McVicker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAT=U9xE5QTPThRTf3V=WEh3WmUh6w-89mm+APjnYp701Q@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).