From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] kbuild: remove dead code in cmd_files calculation in top Makefile
Date: Fri, 14 Sep 2018 22:06:33 +0900 [thread overview]
Message-ID: <CAK7LNATHOOLA+Hje0VUsxNJWov_nDaBa90SwsKr=QSCa3LYYYQ@mail.gmail.com> (raw)
In-Reply-To: <1536734610-22173-2-git-send-email-yamada.masahiro@socionext.com>
2018-09-12 15:43 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Nobody sets 'targets' in the top-level Makefile or arch/*/Makefile,
> hence $(targets) is empty.
>
> $(wildcard .*.cmd) will do for including the .vmlinux.cmd file.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied to linux-kbuild.
> Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4b76e22..8f6dbfc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1721,8 +1721,7 @@ cmd_crmodverdir = $(Q)mkdir -p $(MODVERDIR) \
> $(if $(KBUILD_MODULES),; rm -f $(MODVERDIR)/*)
>
> # read all saved command lines
> -
> -cmd_files := $(wildcard .*.cmd $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd))
> +cmd_files := $(wildcard .*.cmd)
>
> ifneq ($(cmd_files),)
> $(cmd_files): ; # Do not try to update included dependency files
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-09-14 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 6:43 [PATCH 1/2] kbuild: hide most of targets when running config or mixed targets Masahiro Yamada
2018-09-12 6:43 ` [PATCH 2/2] kbuild: remove dead code in cmd_files calculation in top Makefile Masahiro Yamada
2018-09-14 13:06 ` Masahiro Yamada [this message]
2018-09-14 13:05 ` [PATCH 1/2] kbuild: hide most of targets when running config or mixed targets Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATHOOLA+Hje0VUsxNJWov_nDaBa90SwsKr=QSCa3LYYYQ@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).