From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755457AbdCWByg (ORCPT ); Wed, 22 Mar 2017 21:54:36 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:30518 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbdCWBye (ORCPT ); Wed, 22 Mar 2017 21:54:34 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v2N1s9Ys019146 X-Nifty-SrcIP: [209.85.161.171] MIME-Version: 1.0 In-Reply-To: <20170322223550.1f1c97ae@bbrezillon> References: <1490213273-8571-1-git-send-email-yamada.masahiro@socionext.com> <20170322223550.1f1c97ae@bbrezillon> From: Masahiro Yamada Date: Thu, 23 Mar 2017 10:54:08 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb To: Boris Brezillon Cc: linux-mtd@lists.infradead.org, laurent.monat@idquantique.com, thorsten.christiansson@idquantique.com, Enrico Jorns , Artem Bityutskiy , Dinh Nguyen , Marek Vasut , Graham Moore , David Woodhouse , Masami Hiramatsu , Chuanxiao Dong , Jassi Brar , devicetree@vger.kernel.org, Linux Kernel Mailing List , Brian Norris , Richard Weinberger , Cyrille Pitchen , Rob Herring , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, 2017-03-23 6:35 GMT+09:00 Boris Brezillon : > Hi Masahiro, > > On Thu, 23 Mar 2017 05:06:59 +0900 > Masahiro Yamada wrote: > >> It took a couple months to update this series, but finally here is v2. >> (v1: https://lkml.org/lkml/2016/11/26/144 ) >> >> This driver includes many problems. >> >> One of the biggest one is a bunch of hard-coded parameters. This IP >> has many parameters that can be customized when a delivery RTL is >> generated. However, this driver was upstreamed by Intel, with >> Intel parameters hard-coded. Later, Altera added denali_dt.c to use >> this driver for embedded boards, but they did not fix the code in >> denali.c So, this driver has never worked. Even some DT bindings >> actually turned out wrong. >> >> There are more problems: [1] The driver just retrieves the OOB area as-is >> whereas the controller uses syndrome page layout. [2] Many NAND chip >> specific parameters are hard-coded in the driver. [3] ONFi devices are >> not working [4] It can not read Bad Block Marker >> >> This patch series intends to solve those problems. >> >> Since v1, here are more fixes/improvements: >> - Fix raw/oob callbacks for syndrome page layout >> - Implement setup_data_interface() callback >> - Fix/implement more commands for ONFi devices >> - Allow to skip the driver internal bounce buffer >> - Support PIO in case DMA is not supported >> - Switch from ->cmdfunc over to ->cmd_ctrl > > I'll probably pick a few patches for 4.12, so please wait a bit before > sending a v4. This will be helpful. I was refused by the SMTP server I use (probably due to too much volume at once). Please check the following as well. >> mtd: nand: do not check R/B# for CMD_READID in nand_command(_lp) >> mtd: nand: do not check R/B# for CMD_SET_FEATURES in nand_command(_lp) I noticed them when I switched from ->cmdfunc to ->cmd_ctrl hook. -- Best Regards Masahiro Yamada