From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h
Date: Tue, 8 Nov 2016 10:50:31 +0900 [thread overview]
Message-ID: <CAK7LNATU4enycbY-ch68FGC5F7if7U=6yhS97GEgay3AK0tk3w@mail.gmail.com> (raw)
In-Reply-To: <1478523175.29112.7.camel@tiscali.nl>
Hi Paul,
2016-11-07 21:52 GMT+09:00 Paul Bolle <pebolle@tiscali.nl>:
> On Sun, 2016-11-06 at 12:45 +0900, Masahiro Yamada wrote:
>> The header facilities_src.h is only included from gen_facilities.c
>> and the tool is compiled with the following extra options:
>>
>> HOSTCFLAGS_gen_facilities.o += -Wall $(LINUXINCLUDE)
>>
>> Please note $(LINUXINCLUDE) is expanded into build options including:
>>
>> -include $(srctree)/include/linux/kconfig.h
>>
>> So, the Makefile always forces the tool to include kconfig.h, i.e.,
>> the #include <linux/kconfig.h> directive in the header is redundant.
>
> As far as I can see the only kernel header that gen_facilities.c is actually
> interested in is autoconf.h. (autoconf.h will be included via in kconfig.h.)
> So it seems the odd $(LINUXINCLUDE) variable in that Makefile could be
> replaced with something like:
> -include $(srctree)/include/generated/autoconf.h
This would break O= build because autoconf.h is a generated file.
Rather, it should be
-include $(objtree)/include/generated/autoconf.h
I thought of this at first, but I was not quite sure
if the file path include/generated/autoconf.h is a guaranteed interface.
Basically, now we are supposed to include autoconf.h via kconfig.h.
So, I thought $(LINUXINCLUDE) is a more stable interface
than specifying the exact path to autoconf.h
I doubt that nobody would try to change it, but it is just two my cents.
Anyway, arch/x86/boot/Makefile already
referenced the path to autoconf.h
So, if you want to change it, I will not oppose to it.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2016-11-08 1:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 3:45 [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h Masahiro Yamada
2016-11-06 3:45 ` [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Masahiro Yamada
2016-11-07 7:03 ` Heiko Carstens
2016-11-07 9:50 ` Martin Schwidefsky
2016-11-07 13:13 ` Paul Bolle
2016-11-07 13:38 ` Heiko Carstens
2016-11-08 9:18 ` Paul Bolle
2016-11-07 12:52 ` [PATCH 1/2] s390: delete unneeded #include <linux/kconfig.h> from facilities_src.h Paul Bolle
2016-11-08 1:50 ` Masahiro Yamada [this message]
2016-11-08 9:16 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATU4enycbY-ch68FGC5F7if7U=6yhS97GEgay3AK0tk3w@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).