From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939EFC43613 for ; Sun, 23 Jun 2019 14:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C3C820663 for ; Sun, 23 Jun 2019 14:14:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="xEJOfUUo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfFWOOW (ORCPT ); Sun, 23 Jun 2019 10:14:22 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:45903 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfFWOOW (ORCPT ); Sun, 23 Jun 2019 10:14:22 -0400 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) (authenticated) by conssluserg-01.nifty.com with ESMTP id x5NEEGLB028061 for ; Sun, 23 Jun 2019 23:14:17 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com x5NEEGLB028061 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1561299257; bh=NuvwZgU5VzQ83P+ghCASox//DwIgbA0bWMR3kZMvN4o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xEJOfUUocWnyWNl48IDIhe4EXWlkJf0yxActmOaDbNwmDYHC38bdx9uoElM1M9GqP wD9SDiEqGd/3UCYZLrc+jwWhth6UE8juCnnWu1/wEN6459/JH9X++LrDalzmcNuPHT nnpTbqp6p3MoshQMxaSMDyeF12tolaoj2GSEeSwtrcfmAURvhFv8eEfoVnhRt8t2L7 8QuWCBadcXNOzogzd2qOKWTzNNBlZxqpSCb26WZ3q7tHcTzYRSAcOnIHgxW+tCDf92 dmasqnHgHVoYyduApfF06aVNiqQOHuBImU9hkC4bwyE0eTCC2zVBLu8bjyArVzR4Dk rTvxQD4aj5aSA== X-Nifty-SrcIP: [209.85.217.47] Received: by mail-vs1-f47.google.com with SMTP id u124so6914640vsu.2 for ; Sun, 23 Jun 2019 07:14:17 -0700 (PDT) X-Gm-Message-State: APjAAAUKGo3cyG6137qZVpXvDaF9hlNjTMyjNa1lCfUzRyjdr3v7pvGf M5ZH6Vp0xdTIQSAXtY/kUIK3NDgIZTFXch//DmQ= X-Google-Smtp-Source: APXvYqwie7xjtXMjHUN+TIIxSMQan1QJFChMNteSA1Qakl5NCxQ1GZtJ35sWLOosqjnrSwhu4vf+3bw8E0evMuHRsOk= X-Received: by 2002:a67:f495:: with SMTP id o21mr65723335vsn.54.1561299256313; Sun, 23 Jun 2019 07:14:16 -0700 (PDT) MIME-Version: 1.0 References: <1557666733-19527-1-git-send-email-yamada.masahiro@socionext.com> In-Reply-To: <1557666733-19527-1-git-send-email-yamada.masahiro@socionext.com> From: Masahiro Yamada Date: Sun, 23 Jun 2019 23:13:40 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT To: Ley Foon Tan , nios2-dev@lists.rocketboards.org Cc: Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada wrote: > > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice > with different values, which is pointless and confusing. > > [1] arch/nios2/Kconfig > > config TRACE_IRQFLAGS_SUPPORT > def_bool n > > [2] arch/nios2/Kconfig.debug > > config TRACE_IRQFLAGS_SUPPORT > def_bool y > > [1] is included before [2]. In the Kconfig syntax, the first one > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'. > > The second define in arch/nios2/Kconfig.debug is dead code. > > Signed-off-by: Masahiro Yamada > --- Ping. > arch/nios2/Kconfig.debug | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug > index f1da8a7..a8bc06e 100644 > --- a/arch/nios2/Kconfig.debug > +++ b/arch/nios2/Kconfig.debug > @@ -1,8 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > > -config TRACE_IRQFLAGS_SUPPORT > - def_bool y > - > config EARLY_PRINTK > bool "Activate early kernel debugging" > default y > -- > 2.7.4 > -- Best Regards Masahiro Yamada