linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: dummy-tools, fix inverted tests for gcc
Date: Sat, 6 Mar 2021 19:40:01 +0900	[thread overview]
Message-ID: <CAK7LNATWcu1p=F+zHCTdGK2ZRMjKKOS4DvAWrOnRjc_iKTCKmA@mail.gmail.com> (raw)
In-Reply-To: <20210303104314.24121-1-jslaby@suse.cz>

On Wed, Mar 3, 2021 at 7:43 PM Jiri Slaby <jslaby@suse.cz> wrote:
>
> There is a test in Kconfig which takes inverted value of a compiler
> check:
> * config CC_HAS_INT128
>         def_bool !$(cc-option,$(m64-flag) -D__SIZEOF_INT128__=0)
>
> This results in CC_HAS_INT128 not being in super-config generated by
> dummy-tools. So take this into account in the gcc script.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> ---


Applied to linux-kbuild/fixes.
Thanks.


We could fix init/Kconfig to use the positive logic as follows,
but I guess (hope) this conditional will go away
when we raise the GCC min version next time.
So, I am fine with fixing this in dummy-tools.




diff --git a/init/Kconfig b/init/Kconfig
index 22946fe5ded9..502594a78282 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -849,7 +849,7 @@ config ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH
        bool

 config CC_HAS_INT128
-       def_bool !$(cc-option,$(m64-flag) -D__SIZEOF_INT128__=0) && 64BIT
+       def_bool $(success,echo '__int128 x;' | $(CC) $(CLANG_FLAGS)
-x c - -c -o /dev/null) && 64BIT

 #
 # For architectures that know their GCC __int128 support is sound





-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2021-03-06 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 10:43 [PATCH] kbuild: dummy-tools, fix inverted tests for gcc Jiri Slaby
2021-03-06 10:40 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNATWcu1p=F+zHCTdGK2ZRMjKKOS4DvAWrOnRjc_iKTCKmA@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).