From: Masahiro Yamada <yamada.masahiro@socionext.com> To: Jessica Yu <jeyu@kernel.org> Cc: Matthias Maennich <maennich@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Joel Fernandes <joel@joelfernandes.org>, Martijn Coenen <maco@android.com>, Will Deacon <will.deacon@arm.com>, Michal Marek <michal.lkml@markovi.net>, Will Deacon <will@kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 0/7] module: various bug-fixes and clean-ups for module namespace Date: Thu, 3 Oct 2019 10:26:09 +0900 [thread overview] Message-ID: <CAK7LNATbKVEf8Q82k5374UOQVxFJX1U7eU4ywW-LdGvHOq+tPw@mail.gmail.com> (raw) In-Reply-To: <20191002185701.GA29041@linux-8ccs> H Jessica, On Thu, Oct 3, 2019 at 3:57 AM Jessica Yu <jeyu@kernel.org> wrote: > > +++ Matthias Maennich [27/09/19 14:41 +0100]: > >On Fri, Sep 27, 2019 at 06:35:56PM +0900, Masahiro Yamada wrote: > >> > >>I was hit by some problems caused by the module namespace feature > >>that was merged recently. At least, the breakage of > >>external module builds is a fatal one. I just took a look at the code > >>closer, and I noticed some more issues and improvements. > >> > >>I hope these patches are mostly OK. > >>The 4th patch might have room for argument since it is a trade-off > >>of "cleaner implermentation" vs "code size". > >> > >Thanks Masahiro for taking the time to improve the implementation of the > >symbol namespaces. These are all good points that you addressed! > > Agreed, thanks Masahiro for fixing up all the rough edges! Your series > of fixes look good to me, I will queue this up on modules-next this > week Since these are bug fixes, please send them before v5.4. Thanks. > with the exception of patch 4 - Matthias, you are planning to > submit a patch that would supercede patch 04/07, right? > > Thanks! > > Jessica -- Best Regards Masahiro Yamada
next prev parent reply other threads:[~2019-10-03 1:27 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-27 9:35 Masahiro Yamada 2019-09-27 9:35 ` [PATCH 1/7] modpost: fix broken sym->namespace for external module builds Masahiro Yamada 2019-09-27 9:56 ` Masahiro Yamada 2019-09-27 11:46 ` Matthias Maennich 2019-09-27 9:35 ` [PATCH 2/7] module: swap the order of symbol.namespace Masahiro Yamada 2019-09-27 12:07 ` Matthias Maennich 2019-09-27 9:35 ` [PATCH 3/7] module: rename __kstrtab_ns_* to __kstrtabns_* to avoid symbol conflict Masahiro Yamada 2019-09-27 12:14 ` Matthias Maennich 2019-09-27 9:36 ` [PATCH 4/7] module: avoid code duplication in include/linux/export.h Masahiro Yamada 2019-09-27 9:58 ` Masahiro Yamada 2019-09-27 11:07 ` Rasmus Villemoes 2019-09-27 12:36 ` Matthias Maennich 2019-10-29 19:19 ` Jessica Yu 2019-10-29 21:11 ` Rasmus Villemoes 2019-10-31 10:13 ` Jessica Yu 2019-10-31 11:03 ` Rasmus Villemoes 2019-10-31 11:26 ` Jessica Yu 2019-09-27 9:36 ` [PATCH 5/7] kbuild: fix build error of 'make nsdeps' in clean tree Masahiro Yamada 2019-09-27 12:44 ` Matthias Maennich 2019-09-27 9:36 ` [PATCH 6/7] nsdeps: fix hashbang of scripts/nsdeps Masahiro Yamada 2019-09-27 13:10 ` Matthias Maennich 2019-09-27 9:36 ` [PATCH 7/7] nsdeps: make generated patches independent of locale Masahiro Yamada 2019-09-27 13:27 ` Matthias Maennich 2019-09-27 15:42 ` Masahiro Yamada 2019-09-27 18:14 ` Greg Kroah-Hartman 2019-09-29 1:18 ` Masahiro Yamada 2019-09-29 1:30 ` Masahiro Yamada 2019-10-01 11:46 ` Matthias Maennich 2019-09-29 10:14 ` Greg Kroah-Hartman 2019-09-27 13:41 ` [PATCH 0/7] module: various bug-fixes and clean-ups for module namespace Matthias Maennich 2019-09-27 15:43 ` Masahiro Yamada 2019-10-02 18:57 ` Jessica Yu 2019-10-02 20:43 ` Matthias Maennich 2019-10-03 1:26 ` Masahiro Yamada [this message] 2019-10-03 8:03 ` Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK7LNATbKVEf8Q82k5374UOQVxFJX1U7eU4ywW-LdGvHOq+tPw@mail.gmail.com \ --to=yamada.masahiro@socionext.com \ --cc=gregkh@linuxfoundation.org \ --cc=jeyu@kernel.org \ --cc=joel@joelfernandes.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maco@android.com \ --cc=maennich@google.com \ --cc=michal.lkml@markovi.net \ --cc=will.deacon@arm.com \ --cc=will@kernel.org \ --subject='Re: [PATCH 0/7] module: various bug-fixes and clean-ups for module namespace' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).