From: Masahiro Yamada <masahiroy@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] Makefile: Remove Module.symvers when make clean
Date: Tue, 22 Dec 2020 12:46:06 +0900 [thread overview]
Message-ID: <CAK7LNATcDYrBj-k72=ZSrFxwoBtQOwO=6c8_DyW2rY-C37g3Og@mail.gmail.com> (raw)
In-Reply-To: <1608606010-7412-1-git-send-email-yangtiezhu@loongson.cn>
On Tue, Dec 22, 2020 at 12:00 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> Module.symvers still exists when make clean, remove it.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
NACK.
Module.symver is removed by "make mrproper"
since it is needed for building external modules.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index e30cf02..8235bb7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1468,7 +1468,7 @@ endif # CONFIG_MODULES
>
> # Directories & files removed with 'make clean'
> CLEAN_FILES += include/ksym vmlinux.symvers \
> - modules.builtin modules.builtin.modinfo modules.nsdeps \
> + modules.builtin modules.builtin.modinfo modules.nsdeps Module.symvers\
> compile_commands.json
>
> # Directories & files removed with 'make mrproper'
> --
> 2.1.0
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2020-12-22 3:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 3:00 [PATCH] Makefile: Remove Module.symvers when make clean Tiezhu Yang
2020-12-22 3:46 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATcDYrBj-k72=ZSrFxwoBtQOwO=6c8_DyW2rY-C37g3Og@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=michal.lkml@markovi.net \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).