From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Vinson Lee <vlee@freedesktop.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: uniphier: Fix build with gcc-4.4.
Date: Sat, 3 Dec 2016 10:24:43 +0900 [thread overview]
Message-ID: <CAK7LNATeswNhoFsA90k=qF4Jock0ytNT-pPT6j+0b9MJFJwu9Q@mail.gmail.com> (raw)
In-Reply-To: <1480725436-9628-1-git-send-email-vlee@freedesktop.org>
Hi Vinson,
2016-12-03 9:37 GMT+09:00 Vinson Lee <vlee@freedesktop.org>:
> gcc-4.4 has issues with anonymous unions in initializers.
>
> CC drivers/clk/uniphier/clk-uniphier-sys.o
> drivers/clk/uniphier/clk-uniphier-sys.c:45: error: unknown field ‘factor’ specified in initializer
>
> Fixes: 1574d5722636 ("clk: uniphier: remove unneeded member name for union")
> Signed-off-by: Vinson Lee <vlee@freedesktop.org>
This driver has COMPILE_TEST option, but kbuild test robot
did not mention about this.
This is a bad way of fixing, I think.
(what if a new member is inserted before the union in the future?)
Rather, please revert the bad commit.
> .name = "sd" #ch "-sel", \
> .type = UNIPHIER_CLK_TYPE_MUX, \
> .idx = -1, \
> - .mux = { \
> + { .mux = { \
> .parent_names = { \
> "sd-44m", \
> "sd-33m", \
> @@ -63,7 +63,7 @@
> 0x00001200, \
> 0x00001300, \
> }, \
> - }, \
> + } }, \
> }, \
No, please do not do this.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2016-12-03 1:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 0:37 [PATCH] clk: uniphier: Fix build with gcc-4.4 Vinson Lee
2016-12-03 1:24 ` Masahiro Yamada [this message]
2016-12-06 23:16 ` Stephen Boyd
2016-12-07 1:34 ` Masahiro Yamada
2016-12-07 22:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATeswNhoFsA90k=qF4Jock0ytNT-pPT6j+0b9MJFJwu9Q@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=vlee@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).