From: Masahiro Yamada <masahiroy@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Makefile.build: Add an explicit error for missing ASN.1 compiler
Date: Fri, 25 Sep 2020 02:18:20 +0900 [thread overview]
Message-ID: <CAK7LNATg2MG4xSoHiEa5CvB0x+LYS9ZOGKWz0ytBhBRcvCogoQ@mail.gmail.com> (raw)
In-Reply-To: <20200922155341.17906-2-James.Bottomley@HansenPartnership.com>
On Wed, Sep 23, 2020 at 12:55 AM James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> The current dependency rules mean that the build breaks if the ASN.1
> compiler is required but CONFIG_ASN1 isn't set. However, it isn't
> obvious from the error message about missing files what the actual
> problem is, so make the build system give an explicit error.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> ---
Applied to linux-kbuild.
Thanks.
> scripts/Makefile.build | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index a467b9323442..bca7003beac8 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -382,6 +382,11 @@ quiet_cmd_asn1_compiler = ASN.1 $(basename $@).[ch]
> cmd_asn1_compiler = $(objtree)/scripts/asn1_compiler $< \
> $(basename $@).c $(basename $@).h
>
> +ifndef CONFIG_ASN1
> +$(objtree)/scripts/asn1_compiler:
> + $(error CONFIG_ASN1 must be defined for the asn1_compiler)
> +endif
> +
> $(obj)/%.asn1.c $(obj)/%.asn1.h: $(src)/%.asn1 $(objtree)/scripts/asn1_compiler
> $(call cmd,asn1_compiler)
>
> --
> 2.26.2
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2020-09-24 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 15:53 [PATCH 0/1] Add explicit error for missing CONFIG_ASN1 James Bottomley
2020-09-22 15:53 ` [PATCH 1/1] Makefile.build: Add an explicit error for missing ASN.1 compiler James Bottomley
2020-09-24 17:18 ` Masahiro Yamada [this message]
2020-09-22 18:54 ` [PATCH 0/1] Add explicit error for missing CONFIG_ASN1 Randy Dunlap
2020-09-22 19:19 ` James Bottomley
2020-09-22 19:38 ` Randy Dunlap
2020-09-22 19:44 ` James Bottomley
2020-09-22 19:46 ` Randy Dunlap
2020-09-22 19:48 ` James Bottomley
2020-09-22 19:52 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNATg2MG4xSoHiEa5CvB0x+LYS9ZOGKWz0ytBhBRcvCogoQ@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).