From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Michal Marek <mmarek@suse.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH 2/2] kbuild: remove initramfs cpio with mrproper
Date: Wed, 3 May 2017 13:10:52 +0900 [thread overview]
Message-ID: <CAK7LNATjXkvuRO7iF7uAa1WwWSAH-JxGv6-ksVrdTaMJOhgbKg@mail.gmail.com> (raw)
In-Reply-To: <20170414215450.18307-3-sthemmin@microsoft.com>
Hi Stephen,
2017-04-15 6:54 GMT+09:00 Stephen Hemminger <stephen@networkplumber.org>:
> When 'make mrproper' is done, it should also remove the initramfs cpio
> file. I ran into this while doing test build on one machine, followed
> by make mrproper and rsync to a target machine. The build on the target
> machine would succeed but be unbootable because of the bad initramfs.
I think initramfs_data.cpio.* is unneeded for external modules.
So, shouldn't it removed by 'make clean', instead of 'make mrproper'?
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 04ca211552f7..954292695bf6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1276,7 +1276,8 @@ MRPROPER_FILES += .config .config.old .version .old_version \
> Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
> certs/signing_key.pem certs/signing_key.priv certs/signing_key.x509 \
> certs/x509.genkey certs/extra_certificates certs/signing_key.x509.keyid \
> - certs/signing_key.x509.signer vmlinux-gdb.py
> + certs/signing_key.x509.signer vmlinux-gdb.py \
> + usr/initramfs_data.cpio.gz
>
As you see usr/Makefile,
datafile_y = initramfs_data.cpio$(suffix_y)
The suffix could be .gz, .bz2, .xz, etc.
Why only initramfs_data.cpio.gz?
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2017-05-03 4:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 21:54 [PATCH 0/2] make mrproper cleanup more file Stephen Hemminger
2017-04-14 21:54 ` [PATCH 1/2] kbuild: cleanup signing keys with mrproper Stephen Hemminger
2017-05-03 4:37 ` Masahiro Yamada
2017-05-11 17:25 ` Stephen Hemminger
2017-06-05 9:12 ` Masahiro Yamada
2017-04-14 21:54 ` [PATCH 2/2] kbuild: remove initramfs cpio " Stephen Hemminger
2017-05-03 4:10 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNATjXkvuRO7iF7uAa1WwWSAH-JxGv6-ksVrdTaMJOhgbKg@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).