From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56358C433EF for ; Tue, 10 May 2022 06:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237459AbiEJHBC (ORCPT ); Tue, 10 May 2022 03:01:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237417AbiEJHAr (ORCPT ); Tue, 10 May 2022 03:00:47 -0400 Received: from conssluserg-03.nifty.com (conssluserg-03.nifty.com [210.131.2.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 532787485B; Mon, 9 May 2022 23:56:48 -0700 (PDT) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 24A6uWPt006909; Tue, 10 May 2022 15:56:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 24A6uWPt006909 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1652165793; bh=fEURvXR77OoRUwAby4ssOCC2y+9cYzZS2BTBBdHY5s4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=wCwaSRXELTeXaq2guIuReTuZg7U66E7IGNEBvRfkfezGlyZXsSMCiDdUr9QEJxarS XrfMKl2ilUNX5U21uZSXL6zLwnIp0vZsPMbwwzeaW+huMjJN0lDJ6x9fPRe4b3ioLX d1CWYofvXhCGeTNOH4b2zCthanuoTTMVhHVGhU/G+RblgSvtBBoQY1q8W0F5FwtyK8 pFbA+pcE2bpadKfX8PQAdO+AHk9AEs+Qvcqfz+EpBxXnZR+DExiobCnjj/rrTS0tnx CZPaFmdEMVXzwdp/7Jw3Kyv3btpFQ7MhJ18jWwmea1L+fCMHlCb2QwIfpTWtpSAEz9 0NOjUjI1wdR0w== X-Nifty-SrcIP: [209.85.216.46] Received: by mail-pj1-f46.google.com with SMTP id iq10so15115325pjb.0; Mon, 09 May 2022 23:56:33 -0700 (PDT) X-Gm-Message-State: AOAM530Yx4NqOCrZWxlmZ6whAaURMPWAefNzWF9V/GNdyNORuj3wUXlF /LFU6ldwJ4z2CmT+9xRoarpYmzRcrA+ynNgI9jQ= X-Google-Smtp-Source: ABdhPJyEgi0eqH+b8oqMunpHr855g62eqCOt9y9rnuZ3PqXxdNPec+4B1Ab1EtAdW8GXjXd92AJ/4rFTNMbUFO627GA= X-Received: by 2002:a17:90a:e7cd:b0:1dc:74eb:7526 with SMTP id kb13-20020a17090ae7cd00b001dc74eb7526mr21753943pjb.144.1652165792292; Mon, 09 May 2022 23:56:32 -0700 (PDT) MIME-Version: 1.0 References: <20220508190631.2386038-1-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Tue, 10 May 2022 15:55:21 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 00/14] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) To: Nathan Chancellor Cc: Linux Kbuild mailing list , Linux Kernel Mailing List , Nick Desaulniers , Nicolas Schier , Peter Zijlstra , linux-modules , linux-s390 , linuxppc-dev , clang-built-linux , Ard Biesheuvel , Sami Tolvanen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 7:13 AM Nathan Chancellor wrote: > > On Mon, May 09, 2022 at 01:24:33PM +0900, Masahiro Yamada wrote: > > On Mon, May 9, 2022 at 4:09 AM Masahiro Yamada wrote: > > > > > > This is the third batch of cleanups in this development cycle. > > > > > > Major changes in v4: > > > - Move static EXPORT_SYMBOL check to a script > > > - Some refactoring > > > > > > Major changes in v3: > > > > > > - Generate symbol CRCs as C code, and remove CONFIG_MODULE_REL_CRCS. > > > > > > Major changes in v2: > > > > > > - V1 did not work with CONFIG_MODULE_REL_CRCS. > > > I fixed this for v2. > > > > > > - Reflect some review comments in v1 > > > > > > - Refactor the code more > > > > > > - Avoid too long argument error > > > > This series is available at > > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > > lto-cleanup-v4 > > Hi Masahiro, > > I checked this out and went to run it through my QEMU tests but I see > two new errors. > > Failure #1: > > In file included from scripts/mod/section-check.c:3: > scripts/mod/modpost.h:15:10: fatal error: 'elfconfig.h' file not found > #include "elfconfig.h" > ^~~~~~~~~~~~~ > 1 error generated. > > I was able to get past that with > > diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile > index ca739c6c68a1..c33b83bfbcad 100644 > --- a/scripts/mod/Makefile > +++ b/scripts/mod/Makefile > @@ -16,7 +16,7 @@ targets += $(devicetable-offsets-file) devicetable-offsets.s > > # dependencies on generated files need to be listed explicitly > > -$(obj)/modpost.o $(obj)/file2alias.o $(obj)/sumversion.o: $(obj)/elfconfig.h > +$(obj)/modpost.o $(obj)/file2alias.o $(obj)/sumversion.o $(obj)/section-check.o: $(obj)/elfconfig.h > $(obj)/file2alias.o: $(obj)/$(devicetable-offsets-file) > Thanks for testing. I will slightly refactor the code as follows. @@ -16,7 +16,7 @@ targets += $(devicetable-offsets-file) devicetable-offsets.s # dependencies on generated files need to be listed explicitly -$(obj)/modpost.o $(obj)/file2alias.o $(obj)/sumversion.o: $(obj)/elfconfig.h +$(addprefix $(obj)/, $(modpost-objs)): $(obj)/elfconfig.h $(obj)/file2alias.o: $(obj)/$(devicetable-offsets-file) quiet_cmd_elfconfig = MKELF $@ > quiet_cmd_elfconfig = MKELF $@ > > Failure #2: > > GEN .version > CHK include/generated/compile.h > GEN .tmp_initcalls.lds > LTO vmlinux.o > OBJTOOL vmlinux.o > MODPOST vmlinux.symvers > MODINFO modules.builtin.modinfo > GEN modules.builtin > LD .tmp_vmlinux.btf > ld.lld: error: cannot open .vmlinux.export.o: No such file or directory > BTF .btf.vmlinux.bin.o > pahole: .tmp_vmlinux.btf: No such file or directory > CC .vmlinux.export.c > LD .tmp_vmlinux.kallsyms1 > ld.lld: error: .btf.vmlinux.bin.o: unknown file type > make[1]: *** [Makefile:1159: vmlinux] Error 1 > > I was not really able to see what is going wrong here. Attached is the > configuration that I ran into this with. If you need any other > information, please let me know! Ah, OK. This is because .vmlinux.export.o is compiled after gen_btf. I will swap the order in v5. > Cheers, > Nathan -- Best Regards Masahiro Yamada