From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754448Ab3F1Dbj (ORCPT ); Thu, 27 Jun 2013 23:31:39 -0400 Received: from mail-we0-f178.google.com ([74.125.82.178]:47813 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753950Ab3F1Dbh (ORCPT ); Thu, 27 Jun 2013 23:31:37 -0400 MIME-Version: 1.0 In-Reply-To: <20130627193138.GB30433@spo001.leaseweb.com> References: <1370167987-14252-1-git-send-email-anish198519851985@gmail.com> <20130627193138.GB30433@spo001.leaseweb.com> Date: Fri, 28 Jun 2013 09:01:36 +0530 Message-ID: Subject: Re: [PATCH] [RFC]Watchdog:core: constant pinging until userspace timesout when delay very less From: anish singh To: Wim Van Sebroeck Cc: Guenter Roeck , linux-watchdog@vger.kernel.org, linux-kernel-mail Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 28, 2013 at 1:01 AM, Wim Van Sebroeck wrote: > Hi Anish, > >> Certain watchdog drivers use a timer to keep kicking the watchdog at >> a rate of 0.5s (HZ/2) untill userspace times out.They do this as >> we can't guarantee that watchdog will be pinged fast enough >> for all system loads, especially if timeout is configured for >> less than or equal to 1 second(basically small values). >> >> As suggested by Wim Van Sebroeck & Guenter Roeck we should >> add this functionality of individual watchdog drivers in the core >> watchdog core. > > Have you considered the effect this change has on all watchdog drivers > that don't need a timer? No,I will drop this patch. > > Kind regards, > Wim. >