linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <kholk11@gmail.com>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	marijns95@gmail.com, Konrad Dybcio <konradybcio@gmail.com>,
	martin.botka1@gmail.com, MSM <linux-arm-msm@vger.kernel.org>,
	phone-devel@vger.kernel.org,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-pm@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] interconnect: qcom: Add SDM660 interconnect provider driver
Date: Fri, 4 Dec 2020 19:06:09 +0100	[thread overview]
Message-ID: <CAK7fi1ZC8F57WmDg57tAS=b++ewjPcMhBXmeuM7Cjqkp-5Zu9Q@mail.gmail.com> (raw)
In-Reply-To: <24ad51dd-ff54-35af-a7bc-92d8cfa30c48@linaro.org>

Il giorno mar 3 nov 2020 alle ore 17:24 Georgi Djakov
<georgi.djakov@linaro.org> ha scritto:
>
> On 10/17/20 16:37, kholk11@gmail.com wrote:
> > From: AngeloGioacchino Del Regno <kholk11@gmail.com>
> >
> > Introduce a driver for the Qualcomm interconnect busses found in
> > the SDM630/SDM636/SDM660 SoCs.
> > The topology consists of several NoCs that are controlled by a
> > remote processor that collects the aggregated bandwidth for each
> > master-slave pairs.
> >
> > On a note, these chips are managing the "bus QoS" in a "hybrid"
> > fashion: some of the paths in the topology are managed through
> > (and by, of course) the RPM uC, while some others are "AP Owned",
> > meaning that the AP shall do direct writes to the appropriate
> > QoS registers for the specific paths and ports, instead of sending
> > an indication to the RPM and leaving the job to that one.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> > ---
> >  drivers/interconnect/qcom/Kconfig  |   9 +
> >  drivers/interconnect/qcom/Makefile |   2 +
> >  drivers/interconnect/qcom/sdm660.c | 922 +++++++++++++++++++++++++++++
> >  3 files changed, 933 insertions(+)
> >  create mode 100644 drivers/interconnect/qcom/sdm660.c
> >
> [..]> +static const struct of_device_id sdm660_noc_of_match[] = {
> > +     { .compatible = "qcom,sdm660-a2noc", .data = &sdm660_a2noc },
> > +     { .compatible = "qcom,sdm660-bimc", .data = &sdm660_bimc },
> > +     { .compatible = "qcom,sdm660-cnoc", .data = &sdm660_cnoc },
> > +     { .compatible = "qcom,sdm660-gnoc", .data = &sdm660_gnoc },
> > +     { .compatible = "qcom,sdm660-mnoc", .data = &sdm660_mnoc },
> > +     { .compatible = "qcom,sdm660-snoc", .data = &sdm660_snoc },
> > +     { },
> > +};
> > +MODULE_DEVICE_TABLE(of, sdm660_noc_of_match);
> > +
> > +static struct platform_driver sdm660_noc_driver = {
> > +     .probe = qnoc_probe,
> > +     .remove = qnoc_remove,
> > +     .driver = {
> > +             .name = "qnoc-sdm660",
> > +             .of_match_table = sdm660_noc_of_match,
>
> Just noticed that here we should set the sync_state callback:
>                 .sync_state = icc_sync_state,
>
> I will fix it up before applying. Are you planning to send a patch
> that adds the DT nodes?
>
> Thanks,
> Georgi
>
I'm sorry for the extremely late reply... Anyway, yes, we have lots of
patches that are bringing up almost the entire feature set in the
SDM630/660 SoCs and we are waiting for them to get merged in
before sending the DT updates.

Cheers,
Angelo

> > +     },
> > +};
> > +module_platform_driver(sdm660_noc_driver);
> > +MODULE_DESCRIPTION("Qualcomm sdm660 NoC driver");
> > +MODULE_LICENSE("GPL v2");

  reply	other threads:[~2020-12-04 18:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 13:37 [PATCH v4 0/2] Add SDM630/636/660 interconnect driver kholk11
2020-10-17 13:37 ` [PATCH v4 1/2] dt-bindings: interconnect: Add bindings for Qualcomm SDM660 NoC kholk11
2020-10-19 19:56   ` Rob Herring
2020-10-19 19:58   ` Rob Herring
2020-10-19 20:44     ` Martin Botka
2020-11-30 14:29       ` Rob Herring
2020-11-30 14:52         ` Georgi Djakov
2020-10-17 13:37 ` [PATCH v4 2/2] interconnect: qcom: Add SDM660 interconnect provider driver kholk11
2020-11-03 16:24   ` Georgi Djakov
2020-12-04 18:06     ` AngeloGioacchino Del Regno [this message]
2021-02-08 22:09       ` Konrad Dybcio
2021-02-09 10:53         ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7fi1ZC8F57WmDg57tAS=b++ewjPcMhBXmeuM7Cjqkp-5Zu9Q@mail.gmail.com' \
    --to=kholk11@gmail.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=georgi.djakov@linaro.org \
    --cc=konradybcio@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marijns95@gmail.com \
    --cc=martin.botka1@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v4 2/2] interconnect: qcom: Add SDM660 interconnect provider driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).