From: Arnd Bergmann <arnd@arndb.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/8] virt: vbox: Fix VBGL_IOCTL_VMMDEV_REQUEST_BIG and _LOG req numbers to match upstream
Date: Wed, 20 May 2020 23:42:27 +0200 [thread overview]
Message-ID: <CAK8P3a03dcvaQxHOOvTtuqPoDzt0j0EOs2YSRcwT93H-fU09_Q@mail.gmail.com> (raw)
In-Reply-To: <20200520195440.38759-1-hdegoede@redhat.com>
On Wed, May 20, 2020 at 9:54 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Until this commit the mainline kernel version (this version) of the
> vboxguest module contained a bug where it defined
> VBGL_IOCTL_VMMDEV_REQUEST_BIG and VBGL_IOCTL_LOG using
> _IOC(_IOC_READ | _IOC_WRITE, 'V', ...) instead of
> _IO(V, ...) as the out of tree VirtualBox upstream version does.
>
> Since the VirtualBox userspace bits are always built against VirtualBox
> upstream's headers, this means that so far the mainline kernel version
> of the vboxguest module has been failing these 2 ioctls with -ENOTTY.
> I guess that VBGL_IOCTL_VMMDEV_REQUEST_BIG is never used causing us to
> not hit that one and sofar the vboxguest driver has failed to actually
> log any log messages passed it through VBGL_IOCTL_LOG.
>
> This commit changes the VBGL_IOCTL_VMMDEV_REQUEST_BIG and VBGL_IOCTL_LOG
> defines to match the out of tree VirtualBox upstream vboxguest version,
> while keeping compatibility with the old wrong request defines so as
> to not break the kernel ABI in case someone has been using the old
> request defines.
>
> Fixes: f6ddd094f579 ("virt: Add vboxguest driver for Virtual Box Guest integration UAPI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Indeed, this sounds like the best fix
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2020-05-20 21:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 19:54 [PATCH 1/8] virt: vbox: Fix VBGL_IOCTL_VMMDEV_REQUEST_BIG and _LOG req numbers to match upstream Hans de Goede
2020-05-20 19:54 ` [PATCH 2/8] virt: vbox: Fix guest capabilities mask check Hans de Goede
2020-05-20 19:54 ` [PATCH 3/8] virt: vbox: Rename guest_caps struct members to set_guest_caps Hans de Goede
2020-05-20 19:54 ` [PATCH 4/8] virt: vbox: Add vbg_set_host_capabilities() helper function Hans de Goede
2020-05-20 19:54 ` [PATCH 5/8] virt: vbox: Add support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl Hans de Goede
2020-05-20 21:47 ` Arnd Bergmann
2020-06-23 13:09 ` Hans de Goede
2020-05-20 19:54 ` [PATCH 6/8] virt: vbox: Add a few new vmmdev request types to the userspace whitelist Hans de Goede
2020-05-20 19:54 ` [PATCH 7/8] virt: vbox: Log unknown ioctl requests as error Hans de Goede
2020-05-20 21:43 ` Arnd Bergmann
2020-05-20 19:54 ` [PATCH 8/8] virt: vbox: Fix some comments which talk about the "session spinlock" Hans de Goede
2020-05-20 21:42 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a03dcvaQxHOOvTtuqPoDzt0j0EOs2YSRcwT93H-fU09_Q@mail.gmail.com \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).