From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932605AbeCLRHH (ORCPT ); Mon, 12 Mar 2018 13:07:07 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:38604 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932570AbeCLRHE (ORCPT ); Mon, 12 Mar 2018 13:07:04 -0400 X-Google-Smtp-Source: AG47ELsZ+Ay2+oeuaLtB8/DNqdC4eA15P6QtLmLnCnS/vAPIvKkwLdw33MHPQd6M5KKWvl7wjO8YGDggkZZKYaNieeo= MIME-Version: 1.0 In-Reply-To: References: <20180220215954.4092811-1-arnd@arndb.de> <20180220215954.4092811-2-arnd@arndb.de> From: Arnd Bergmann Date: Mon, 12 Mar 2018 18:07:01 +0100 X-Google-Sender-Auth: SxBxjuErwxwfvSUpAb866xyWf0s Message-ID: Subject: Re: [PATCH 1/7] ARM: disallow combining XIP and LTO To: Nicolas Pitre Cc: Andi Kleen , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 12, 2018 at 6:00 PM, Nicolas Pitre wrote: > On Mon, 12 Mar 2018, Arnd Bergmann wrote: > >> On Mon, Mar 12, 2018 at 2:52 PM, Arnd Bergmann wrote: >> > On Mon, Mar 12, 2018 at 3:40 AM, Nicolas Pitre wrote: >> >> On Tue, 20 Feb 2018, Arnd Bergmann wrote: >> > >> >>> Obviously we want to make the combination work, no idea why it doesn't. >> >> >> >> Well, it does work regardless of the noise. Here the nm output is piped >> >> into sed, and the later exits early when it finds what it is looking >> >> for, causing nm to complain about the broken pipe. >> >> >> >> Here's a patch silencing this bogus error message and fixing other minor >> >> issues. >> >> >> >> ----- >8 >> >> Subject: [PATCH] ARM: deflate_xip_data.sh: minor fixes >> >> >> >> Send nm complaints about broken pipe (when sed exits early) to /dev/null. >> >> All errors should be printed to stderr. >> >> Don't trap on normal exit so the trap can return an error code. >> >> >> >> Signed-off-by: Nicolas Pitre >> > >> > Ah, that explains it, thanks! >> > >> > Tested-by: Arnd Bergmann >> >> >> Nevermind, I confused it with a different problem that I'm running into >> with randconfig builds: > > At least you no longer get the "broken pipe" warning as your initial > report showed, right? I don't know, my recent tests are all without the LTO patch series, so I don't get that one anyway. >> arm-linux-gnueabi-nm: 'arch/arm/boot/compressed/../../../../vmlinux': >> No such file > > That is weird. The Makefile has: > > cmd_mkxip = $(cmd_objcopy) && $(cmd_deflate_xip_data) > > $(obj)/xipImage: vmlinux FORCE > $(call if_changed,mkxip) > > So the objcopy must succeed at producing vmlinux for deflate_xip_data > (where nm is used) to be called. > > Do you have a .config for this issue? I only get it while doing randconfig builds with my scripts, maybe one out of three times, but don't ever get when rebuilding the configs later. I have never figured out how to reproduce it reliably other than with my randconfig script: #!/bin/bash RAND_DIR=build/rand LOG_DIR=rand PARALLEL="-j30" # number of CPUs on build system MAKE="make O=${RAND_DIR} -sk ${PARALLEL}" export CCACHE_DISABLE=1 # no point in ccache for random builds buildone() { mkdir -p ${RAND_DIR} ${LOG_DIR} eval `${MAKE} randconfig 2>&1 | grep KCONFIG_SEED=` export KCONFIG_SEED ${MAKE} allrandom.config > /dev/null rm -rf ${RAND_DIR}/arch/arm64/kernel/vdso ID=${KCONFIG_SEED} cp ${RAND_DIR}/.config ${LOG_DIR}/$ID-config if ${MAKE} > ${LOG_DIR}/$ID-output 2>&1 ; then mv ${LOG_DIR}/$ID-output ${LOG_DIR}/$ID-success echo $ID `date` success else mv ${LOG_DIR}/$ID-output ${LOG_DIR}/$ID-failure echo $ID `date` failed ${MAKE} fi ${MAKE} clean } buildone Arnd