From: Arnd Bergmann <arnd@arndb.de>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Tri Vo <trong@android.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: Ensure that NEON code always compiles with Clang
Date: Mon, 11 Mar 2019 17:21:56 +0100 [thread overview]
Message-ID: <CAK8P3a05QL855mx21R-Pr6c2WjhSoopdFk9z4HvKoeM19A5aSQ@mail.gmail.com> (raw)
In-Reply-To: <20181215212304.19390-1-natechancellor@gmail.com>
On Sat, Dec 15, 2018 at 10:24 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
> endif
> diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c
> index a6741a895189..4600b62d845f 100644
> --- a/arch/arm/lib/xor-neon.c
> +++ b/arch/arm/lib/xor-neon.c
> @@ -14,7 +14,7 @@
> MODULE_LICENSE("GPL");
>
> #ifndef __ARM_NEON__
> -#error You should compile this file with '-mfloat-abi=softfp -mfpu=neon'
> +#error You should compile this file with '-march=armv7-a -mfloat-abi=softfp -mfpu=neon'
> #endif
>
I see this patch has made it in now, but I also see two other problems with the
same file that prevent it from working right with clang:
- it triggers #warning This code requires at least version 4.6 of GCC
- As I reported in https://bugs.llvm.org/show_bug.cgi?id=40976, even
when it builds cleanly, it does not get vectorized.
Has anyone actually managed to get this to do the right thing?
Arnd
next prev parent reply other threads:[~2019-03-11 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 21:23 [PATCH] ARM: Ensure that NEON code always compiles with Clang Nathan Chancellor
2018-12-17 18:23 ` Nicolas Pitre
2018-12-17 19:34 ` Nathan Chancellor
2018-12-21 18:11 ` Nick Desaulniers
2019-01-26 4:01 ` [PATCH RESEND] " Nathan Chancellor
2019-01-26 16:48 ` Stefan Agner
2019-03-11 16:21 ` Arnd Bergmann [this message]
2019-03-11 16:49 ` [PATCH] " Ard Biesheuvel
2019-03-11 21:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a05QL855mx21R-Pr6c2WjhSoopdFk9z4HvKoeM19A5aSQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=ard.biesheuvel@linaro.org \
--cc=corbet@lwn.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nicolas.pitre@linaro.org \
--cc=trong@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).