From: Arnd Bergmann <arnd@arndb.de>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Firoz Khan <firoz.khan@linaro.org>,
Chris Zankel <chris@zankel.net>,
linux-xtensa@linux-xtensa.org,
gregkh <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v1 4/4] xtensa: generate uapi header and syscall table header files
Date: Tue, 6 Nov 2018 14:34:31 +0100 [thread overview]
Message-ID: <CAK8P3a07Qtr3h0R83ec_7p6_tDxWtQ6qzUnAM=uR5RkGTkRkGQ@mail.gmail.com> (raw)
In-Reply-To: <CAMo8BfKaSUTMT0h2jRg2ysRnc2yvVT-3=-gq6pH-XpKm1iydQQ@mail.gmail.com>
On Mon, Nov 5, 2018 at 10:44 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
> On Thu, Nov 1, 2018 at 6:57 AM Firoz Khan <firoz.khan@linaro.org> wrote:
> > index 82c75643..b35d2e6 100644
> > --- a/arch/xtensa/include/asm/Kbuild
> > +++ b/arch/xtensa/include/asm/Kbuild
> > @@ -28,3 +28,4 @@ generic-y += topology.h
> > generic-y += trace_clock.h
> > generic-y += word-at-a-time.h
> > generic-y += xor.h
> > +generic-y += syscall_table.h
>
> This doesn't look right: syscall_table.h is not asm-generic header.
>
> > diff --git a/arch/xtensa/include/uapi/asm/Kbuild b/arch/xtensa/include/uapi/asm/Kbuild
> > index 837d4dd..f826d52 100644
> > --- a/arch/xtensa/include/uapi/asm/Kbuild
> > +++ b/arch/xtensa/include/uapi/asm/Kbuild
> > @@ -11,3 +11,4 @@ generic-y += resource.h
> > generic-y += siginfo.h
> > generic-y += statfs.h
> > generic-y += termios.h
> > +generic-y += unistd_32.h
>
> Ditto: unistd32_.h is not asm-generic header.
I think the correct syntax here would be
generated-y += unistd_32.h
Firoz, if I remember correctly, this came up before, maybe you just did
not update all architectures together?
Arnd
next prev parent reply other threads:[~2018-11-06 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 13:56 [PATCH v1 0/4] xtensa: system call table generation support Firoz Khan
2018-11-01 13:56 ` [PATCH v1 1/4] xtensa: move SYS_XTENSA_* macros to non uapi header Firoz Khan
2018-11-05 21:28 ` Max Filippov
2018-11-06 2:29 ` Firoz Khan
2018-11-01 13:56 ` [PATCH v1 2/4] xtensa: add __NR_syscalls along with __NR_syscall_count Firoz Khan
2018-11-01 13:56 ` [PATCH v1 3/4] xtensa: add system call table generation support Firoz Khan
2018-11-01 13:56 ` [PATCH v1 4/4] xtensa: generate uapi header and syscall table header files Firoz Khan
2018-11-05 21:44 ` Max Filippov
2018-11-06 4:21 ` Firoz Khan
2018-11-06 13:34 ` Arnd Bergmann [this message]
2018-11-06 15:12 ` Firoz Khan
2018-11-06 20:24 ` Max Filippov
2018-11-07 5:01 ` Firoz Khan
2018-11-06 20:30 ` [PATCH v1 0/4] xtensa: system call table generation support Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a07Qtr3h0R83ec_7p6_tDxWtQ6qzUnAM=uR5RkGTkRkGQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=deepa.kernel@gmail.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).