From: Arnd Bergmann <arnd@arndb.de>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG
Date: Wed, 22 Mar 2017 15:51:54 +0100 [thread overview]
Message-ID: <CAK8P3a0A0-gnBnBBuWdPjgoDMo=2P9yXcLjZYm9Yz+xpQnCyCw@mail.gmail.com> (raw)
In-Reply-To: <20170322143729.GB25645@e104818-lin.cambridge.arm.com>
On Wed, Mar 22, 2017 at 3:37 PM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> Hi Arnd,
>
> On Tue, Mar 14, 2017 at 10:39:21PM +0100, Arnd Bergmann wrote:
>> This mirrors commit e9c38ceba8d9 ("ARM: 8455/1: define __BUG as
>> asm(BUG_INSTR) without CONFIG_BUG") to make the behavior of
>> arm64 consistent with arm and x86, and avoids lots of warnings in
>> randconfig builds, such as:
>>
>> kernel/seccomp.c: In function '__seccomp_filter':
>> kernel/seccomp.c:666:1: error: no return statement in function returning non-void [-Werror=return-type]
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> A side-effect of this patch is that it turns WARN into BUG. I hit the
> WARN_ONCE in arch/arm64/kernel/efi.c:34 (on Juno with 64K pages) and
> with your patch applied, the kernel panics.
Taht was certainly not intended, and I don't see yet what exactly is going on.
What is your setting for CONFIG_BUG and CONFIG_BUGVERBOSE?
Arnd
next prev parent reply other threads:[~2017-03-22 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 21:39 [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann
2017-03-20 19:09 ` Will Deacon
2017-03-21 10:35 ` Arnd Bergmann
2017-03-21 11:51 ` Will Deacon
2017-03-21 14:11 ` Catalin Marinas
2017-03-22 14:37 ` Catalin Marinas
2017-03-22 14:51 ` Arnd Bergmann [this message]
2017-03-22 15:32 ` Catalin Marinas
2017-03-22 16:29 ` Arnd Bergmann
2017-03-22 16:57 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0A0-gnBnBBuWdPjgoDMo=2P9yXcLjZYm9Yz+xpQnCyCw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).