linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Wang Kefeng <wangkefeng.wang@huawei.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amba: Drop builtin_amba_driver()
Date: Thu, 19 May 2022 11:53:55 +0100	[thread overview]
Message-ID: <CAK8P3a0EGC-sBBdW_84WOoehbKAa39oX6gv4gqwkSK8p64PrYg@mail.gmail.com> (raw)
In-Reply-To: <f8b83f8e-eb99-16e4-4e9a-dca58971b437@arm.com>

On Thu, May 19, 2022 at 4:08 AM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
> On 5/18/22 17:50, Arnd Bergmann wrote:
> > On Tue, May 17, 2022 at 7:29 AM Anshuman Khandual
> > <anshuman.khandual@arm.com> wrote:
> >>
> >> Drop builtin_amba_driver() which is not used anymore.
> >
> > The patch looks correct, but I don't see the purpose. Are you trying
> > to discourage
> > having amba drivers as built-in? Otherwise the next time we get an amba
> > driver that cannot be a loadable module, someone might want to add back the
> > same macro.
>
> Right, then it should be added back. But for now this is just dead code
> and not being used, hence why keep it ?

I don't care if the function is there or not, the interface does exactly what
one expects it to do, and it uses no space in the binary, but most likely
nobody would miss it if it's gone.

However, neither adding nor removing the function by itself to me hits the
threshold of doing a meaningful change that is an overall improvement, so
why send a patch?

The original patch that added the function was similar: the coresight drivers
were written to be loadable modules but Kconfig forced them to be built-in,
so Paul's cleanup to remove the module bits felt like completely pointless
churn that just made it harder for Kim to make them modular again.

If you want to remove the macro out of spite for the original change,
I'm sympathetic with that, but then put this in the patch description ;-)

        Arnd

      reply	other threads:[~2022-05-19 10:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17  6:29 [PATCH] amba: Drop builtin_amba_driver() Anshuman Khandual
2022-05-18 12:20 ` Arnd Bergmann
2022-05-19  3:08   ` Anshuman Khandual
2022-05-19 10:53     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a0EGC-sBBdW_84WOoehbKAa39oX6gv4gqwkSK8p64PrYg@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).