From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01117CA9EB7 for ; Tue, 22 Oct 2019 09:44:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D52DE2084B for ; Tue, 22 Oct 2019 09:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731493AbfJVJox (ORCPT ); Tue, 22 Oct 2019 05:44:53 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:37195 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730619AbfJVJox (ORCPT ); Tue, 22 Oct 2019 05:44:53 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MvbJw-1i3O5t0uak-00shqz; Tue, 22 Oct 2019 11:44:51 +0200 Received: by mail-qt1-f182.google.com with SMTP id g50so11627486qtb.4; Tue, 22 Oct 2019 02:44:50 -0700 (PDT) X-Gm-Message-State: APjAAAUYazSrb3Gwxzn0uEB3Xz5IMLC0WgvMwk7I4JMHZW04/8eMzKLu W4MQVyD5axg4khHD1E6zxkhNUOv0cr+r8Paz+Ac= X-Google-Smtp-Source: APXvYqxUguCPOp5LGMrfhG+G2UL8MgJST6yvwsbwS5pSbXnjYf7SsBUo3nYRm7EHYr0oSYA+LoNeUI92RIaCIkpSbmY= X-Received: by 2002:ac8:18eb:: with SMTP id o40mr2367412qtk.304.1571737490006; Tue, 22 Oct 2019 02:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-9-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Tue, 22 Oct 2019 11:44:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 09/46] watchdog: sa1100: use platform device registration To: Guenter Roeck Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Linus Walleij , Wim Van Sebroeck , "linux-kernel@vger.kernel.org" , Linux ARM , LINUXWATCHDOG Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:TFMiph9iftlPu/I44aOxHFyNWGsYwv4B00XFAtCQdCQRjaJURuI WX3mqNCkEyiZ/JXLGJMfVD2K6/mNI/4Kp3o7KbRltUNfdCUY+x50VGtyfLlj7bqO/v4o93X wmjeQNiEUltJb7EnUQ1Xqzjn+IwKH2I+4D9dNGrx7t+wCtU0GbQkwDSn/9f7ysqT1ShUigM zk3J1dG3cPxUhD0KspWFg== X-UI-Out-Filterresults: notjunk:1;V03:K0:X4jd4H54yL8=:goNIci1sGhaZ5snOezD3LY SDY3Vqyab26QqB+uY3lw810jl/gAFyJHlvKxaNWlSA7igpniuHPPD7S/GmE0QHFbHD423zPu8 gSauNQUlolz55d6vRVdALJc+ox59ZxB3MLAGv8gXwqBn+h/w3AQPDWCrVyLIISFmPNQPnw7j1 4l9ILrEPg36GR38AS/4DUhpXeFvMDOZEVpYsaxzNUlDRXWhmxRwrUqmW34vt51Iukk9lZhGg4 9wNyu0SRtSLK0RevCxH4r3T1ndkOvwhJ3xs3P/4vMG7GLn8n5yHbi6/wzXvznl+SrpJxihfns 90xoTMDm68xxfVZB264HjxWQdHMRSkiNwyoeUGNVWusRlK0kJaZz9ANTiVgWxtGbUkkNZMpFF b8zTOFcrgAUcO3KpK32UCBlfYxAYi/WhSX9zOV7dFCVWhYke9XOMvDlkVAKuzttotrChooPRB 0e8SIJGLyc8KrzLjCkmaXbqZJ2apuNDkqH9ZH6lVFYMOvgNMExLghjb2SyJhZreSzKQ43+943 vRVErfeXavgvoQDvN9HfFCeID1f5tE1+xa51xnpDhlbZzIQSIwRMfsizRBdPD3T3b2WjbQSvq AsKnb5mv6pVNCRyf0hO4NPWoqvepcsNyaoAxKJ34QWpZe25NSrnc6pCUqS7mQ+KxOlxfy1hAB 8jJxpMaToEIcyOY/ZrkM8upYGjzcPjrfxocpKwiOSE/WVmNJErNZbItO+qlOsWAkv4uqAZgz7 VSXZGADqkApGbl97oTPPbuHoz/uapRr4aLBfat5jAPE7pP64NXVOhyO0Kk26Sc3WyGNLTI2xF Rnk3wC3pHUu56QEyn6mSpt76gtasSA+krT0xQ5czQagDsca+KWZTp8XIQ2kMj42k7eQq2MRrq HS8tKj6Njt8EnNW4nMNg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 19, 2019 at 4:07 PM Guenter Roeck wrote: > > @@ -319,10 +316,13 @@ static struct platform_device *sa11x0_devices[] __initdata = { > > > > static int __init sa1100_init(void) > > { > > + struct resource wdt_res = DEFINE_RES_MEM(0x90000000, 0x20); > > pm_power_off = sa1100_power_off; > > > > regulator_has_full_constraints(); > > > > + platform_device_register_simple("sa1100_wdt", -1, &wdt_res, 1); > > + > > return platform_add_devices(sa11x0_devices, ARRAY_SIZE(sa11x0_devices)); > > Wouldn't it be better to add the watchdog device to sa11x0_devices ? Generally speaking, platform_device_register_simple() is better than platform_add_devices(), it does the same thing with fewer source lines and smaller object code, and it doesn't have the problem of lifetime rules for statically allocated reference-counted devices. One day we may want to replace all static platform_device instances with platform_device_info instead, but right now there are too many of those. I can change this one to a platform_device for consistency though if you think it's worth it. Arnd