From: Arnd Bergmann <arnd@arndb.de>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Harald Welte <laforge@gnumonks.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pcmcia/cm4000: remove useless variable tmp
Date: Tue, 21 Jan 2020 10:08:13 +0100 [thread overview]
Message-ID: <CAK8P3a0LJETeKbQvs-EeQ1cF84gVO3JS75SOZYD0F+puWhi9=w@mail.gmail.com> (raw)
In-Reply-To: <1579596599-258299-1-git-send-email-alex.shi@linux.alibaba.com>
On Tue, Jan 21, 2020 at 9:50 AM Alex Shi <alex.shi@linux.alibaba.com> wrote:
>
> No one care the value of 'tmp' in func cmm_write. better to remove it.
Hi Alex,
> @@ -1146,7 +1145,7 @@ static ssize_t cmm_write(struct file *filp, const char __user *buf,
> set_cardparameter(dev);
>
> /* dummy read, reset flag procedure received */
> - tmp = inb(REG_FLAGS1(iobase));
> + inb(REG_FLAGS1(iobase));
I think this may cause warnings on some architectures, when inb() is a macro
that just turns into a pointer dereference. You could write it as
(void)inb(REG_FLAGS1(iobase));
which would not warn anywhere.
Arnd
next prev parent reply other threads:[~2020-01-21 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 8:49 [PATCH] pcmcia/cm4000: remove useless variable tmp Alex Shi
2020-01-21 9:08 ` Arnd Bergmann [this message]
2020-01-21 9:53 ` Alex Shi
2020-01-21 10:13 ` Arnd Bergmann
2020-01-21 16:24 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0LJETeKbQvs-EeQ1cF84gVO3JS75SOZYD0F+puWhi9=w@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=alex.shi@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).