From: Arnd Bergmann <arnd@arndb.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Olof Johansson" <olof@lixom.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
gregkh <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>,
"Andreas Färber" <afaerber@suse.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
linux-serial@vger.kernel.org,
"Amit Kucheria" <amit.kucheria@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
zhao_steven@263.net, overseas.sales@unisoc.com
Subject: Re: [PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board
Date: Wed, 21 Nov 2018 09:55:18 +0100 [thread overview]
Message-ID: <CAK8P3a0OqD=mxJmc2hPTp2s1-i1MPZWsjDF37hjSDKrFpzGxWg@mail.gmail.com> (raw)
In-Reply-To: <20181121033652.12247-7-manivannan.sadhasivam@linaro.org>
On Wed, Nov 21, 2018 at 4:38 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + };
>
+
> +&uart2 {
> + status = "okay";
> + clocks = <&uart2_clk>;
> +};
This is clearly mismatched here: you mark only one uart as 'enabled, but
list three of them as aliases. Having 'serial0' point to a disabled uart
may easily break applications that expect the first one to be the
console.
Best make that
serial0 = &uart2;
and drop the other ones if only one of them is exposed on the
board. If all three are usable, you should enable them all here,
and make sure that the numbering of the aliases matches the
labels on the board or its documentation.
Arnd
next prev parent reply other threads:[~2018-11-21 8:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 3:36 [PATCH v2 00/15] Add initial RDA8810PL SoC and Orange Pi boards support Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 01/15] dt-bindings: Add RDA Micro vendor prefix Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 02/15] dt-bindings: arm: Document RDA8810PL and reference boards Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 03/15] ARM: Prepare RDA8810PL SoC Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 04/15] dt-bindings: interrupt-controller: Document RDA8810PL intc Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 05/15] arm: dts: Add devicetree for RDA8810PL SoC Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board Manivannan Sadhasivam
2018-11-21 8:55 ` Arnd Bergmann [this message]
2018-12-03 15:53 ` Rob Herring
2018-12-03 17:11 ` Olof Johansson
2018-12-03 17:21 ` Rob Herring
2018-12-03 17:53 ` Olof Johansson
2018-11-21 3:36 ` [PATCH v2 07/15] arm: dts: Add devicetree for OrangePi i96 board Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 08/15] irqchip: Add RDA8810PL interrupt driver Manivannan Sadhasivam
2018-11-21 8:41 ` Marc Zyngier
2018-11-21 17:41 ` Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 09/15] dt-bindings: timer: Document RDA8810PL SoC timer Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 10/15] arm: dts: rda8810pl: Add timer support Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 11/15] clocksource: Add clock driver for RDA8810PL SoC Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 12/15] dt-bindings: serial: Document RDA Micro UART Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 13/15] arm: dts: rda8810pl: Add interrupt support for UART Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 14/15] tty: serial: Add RDA8810PL UART driver Manivannan Sadhasivam
2018-11-22 10:09 ` Greg KH
2018-11-21 3:36 ` [PATCH v2 15/15] MAINTAINERS: Add entry for RDA Micro SoC architecture Manivannan Sadhasivam
2018-11-24 8:30 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0OqD=mxJmc2hPTp2s1-i1MPZWsjDF37hjSDKrFpzGxWg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marc.zyngier@arm.com \
--cc=olof@lixom.net \
--cc=overseas.sales@unisoc.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhao_steven@263.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).