From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE36C433DB for ; Tue, 26 Jan 2021 17:37:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65EB722228 for ; Tue, 26 Jan 2021 17:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392445AbhAZRhf (ORCPT ); Tue, 26 Jan 2021 12:37:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:42410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389606AbhAZHqH (ORCPT ); Tue, 26 Jan 2021 02:46:07 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E370322D04 for ; Tue, 26 Jan 2021 07:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611647123; bh=jhq9uwsKX2IsXJllw2EXbtk8GfeJ3kCXzMA1RQNaNRU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XA1r1xhu7WxUb4ik40Pc4JjC+lQfgLdbH5xEcf7isDsK0ldDwAcv3FkQ20CRqre30 S9hJLeqO3ACr+0VvLdtWAkewreMrZzcKI4pNi09GukDOeC205dDQLRBbqQK2Yzkzva pfAzbftqE+zVqgKRGDcn8xV6IpNWgIyxUALpWP3oYckDHn4PZBLa5NZoeEZu2dqybO U6bKMgjTi80zHwD9T8bJW9T4Y4KrTD8WkJawCnbY/eGLQu3wA8kjiZmKhTxP+ij7qD lIhN4kyYivXl2JcbW+B8gVLPylsLloktaZIv9nNXx/Blu6NUcZQn2MNwvQ2DAWlSff KQnZAG5EFMdaA== Received: by mail-oi1-f173.google.com with SMTP id m13so9654229oig.8 for ; Mon, 25 Jan 2021 23:45:22 -0800 (PST) X-Gm-Message-State: AOAM532SMmHHfqijWwnEW0HqxYW8bqn8h3O26R/09DLkdWl4qtJVJ0S7 xOUiSTC+N4DN9pf4XMx2xwulk+xMm6eWRlXhXEI= X-Google-Smtp-Source: ABdhPJyol2UGu37c/P3KJc5DUsRH8kkI4sOp/UiVLrx4W3k+9ZmraqxHJH+SKZIheFO/4gSUMveamqtled5onVFA+4A= X-Received: by 2002:aca:be54:: with SMTP id o81mr2390645oif.67.1611647122191; Mon, 25 Jan 2021 23:45:22 -0800 (PST) MIME-Version: 1.0 References: <20210108212600.36850-1-mgross@linux.intel.com> <20210108212600.36850-30-mgross@linux.intel.com> <20210125233935.GA13745@linux.intel.com> In-Reply-To: <20210125233935.GA13745@linux.intel.com> From: Arnd Bergmann Date: Tue, 26 Jan 2021 08:45:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 29/34] Intel tsens i2c slave driver. To: mgross@linux.intel.com Cc: Randy Dunlap , markgross@kernel.org, Arnd Bergmann , Borislav Petkov , Damien Le Moal , Dragan Cvetic , gregkh , Jonathan Corbet , Leonard Crestez , Palmer Dabbelt , Paul Walmsley , Peng Fan , Rob Herring , Shawn Guo , Jassi Brar , "linux-kernel@vger.kernel.org" , "C, Udhayakumar" , C@linux.intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 12:39 AM mark gross wrote: > > On Mon, Jan 11, 2021 at 11:15:06PM -0800, Randy Dunlap wrote: > > On 1/8/21 1:25 PM, mgross@linux.intel.com wrote: > > > diff --git a/drivers/misc/intel_tsens/Kconfig b/drivers/misc/intel_tsens/Kconfig > > > index 8b263fdd80c3..c2138339bd89 100644 > > > --- a/drivers/misc/intel_tsens/Kconfig > > > +++ b/drivers/misc/intel_tsens/Kconfig > > > @@ -14,6 +14,20 @@ config INTEL_TSENS_LOCAL_HOST > > > Say Y if using a processor that includes the Intel VPU such as > > > Keem Bay. If unsure, say N. > > > > > > +config INTEL_TSENS_I2C_SLAVE > > > + bool "I2C slave driver for intel tsens" > > > > Why bool instead of tristate? > Becuase the I2C driver depends on a file scoped global i2c_plat_data > instanciated in the INTELL_TSENS_LOCAL_HOST DRIVER (intel_tsens_thermal.[ch]) > > Udhaya, would you care to comment further? > > > + depends on INTEL_TSENS_LOCAL_HOST > > > + select I2C > > > + select I2C_SLAVE Please make this 'depends on I2C=y && I2C_SLAVE' instead of 'select' in this case. A random driver should never force-enable another subsystem. Arnd