From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFAF3C19F33 for ; Tue, 27 Jul 2021 18:50:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDFD760FE4 for ; Tue, 27 Jul 2021 18:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbhG0SuK (ORCPT ); Tue, 27 Jul 2021 14:50:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:42654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhG0SuJ (ORCPT ); Tue, 27 Jul 2021 14:50:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 18F3260FE3; Tue, 27 Jul 2021 18:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627411809; bh=FEnwgSbKVXqz/f02D+yC03c3XbgdHc6UQnZBnRvCJ/M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aTvhKIKZ1ioo9DG0Ec9o/GHguV1Ls8Zpgym6pDWcFaNRWivLNiLs3OTCrstGNfOKs GYBakEdIJ12kYhkUhqg+tOIolcIb5CzQ6OTuCoADjYmLiI25p4cgat6MWKirxMzBn/ 352r/ZmRWn/7CQHJO+JzH27w1AHj9B1xK/Nn0TewFpaj1y7GxvPnDYLkim5VS64g0V 06QFD449q6vX6wKDDryuRrutXpXvt77m9GnAp5mB+Al7hIqJmEj1teWUskJ7YYwsIn N+imzTNgxUezFzNwky77iBsCOYrkNrnlOcsOxOnroPd5ezkMaL9zUmOn/CumedaEML +L3MG8J2lY+Mw== Received: by mail-lf1-f51.google.com with SMTP id z2so23497586lft.1; Tue, 27 Jul 2021 11:50:09 -0700 (PDT) X-Gm-Message-State: AOAM532heSb7RK5bbGEQzFPUHQM1OAir3WbFsEk2kNDQHm009XvpN27z wn4NChedsuO829eBRGx5DPkgTp0dph5Ei8wAMqw= X-Google-Smtp-Source: ABdhPJyJoGfE0vjMAu17Dx3oLfkZN1O26Yflb54n4xga3o5XuLKsejT/cbFSiPGK2CJQqQHqBmqSL7vlY8Dk6BlYaZM= X-Received: by 2002:adf:e107:: with SMTP id t7mr26004543wrz.165.1627411796641; Tue, 27 Jul 2021 11:49:56 -0700 (PDT) MIME-Version: 1.0 References: <20210727144859.4150043-1-arnd@kernel.org> <20210727144859.4150043-5-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Tue, 27 Jul 2021 20:49:40 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/6] mm: simplify compat numa syscalls To: Heiko Carstens Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Vasily Gorbik , Christian Borntraeger , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "the arch/x86 maintainers" , "H. Peter Anvin" , Al Viro , "Eric W. Biederman" , Christoph Hellwig , Feng Tang , Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-arch , Linux API , Linux-MM , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 8:38 PM Heiko Carstens wrote: > > -268 common mbind sys_mbind compat_sys_mbind > -269 common get_mempolicy sys_get_mempolicy compat_sys_get_mempolicy > -270 common set_mempolicy sys_set_mempolicy compat_sys_set_mempolicy > +268 common mbind sys_mbind sys_mbind > +269 common get_mempolicy sys_get_mempolicy sys_get_mempolicy > +270 common set_mempolicy sys_set_mempolicy sys_set_mempolicy > > would remove compat_ptr() conversion from nmask above if I'm not mistaken. Maybe I'm misremembering how compat syscalls work on s390. Doesn't SYSCALL_DEFINEx(sys_mbind) still create two entry points __s390x_sys_mbind() and __s390_sys_mbind() with different argument conversion (__SC_CAST vs __SC_COMPAT_CAST)? I thought that was the whole point of the macros. Arnd