From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BD7C433E9 for ; Thu, 4 Mar 2021 09:37:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE1D564F20 for ; Thu, 4 Mar 2021 09:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237678AbhCDJhE (ORCPT ); Thu, 4 Mar 2021 04:37:04 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:48449 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237653AbhCDJgo (ORCPT ); Thu, 4 Mar 2021 04:36:44 -0500 Received: from mail-ot1-f51.google.com ([209.85.210.51]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N30VJ-1llby93tLJ-013P6q; Thu, 04 Mar 2021 10:34:09 +0100 Received: by mail-ot1-f51.google.com with SMTP id v12so25508865ott.10; Thu, 04 Mar 2021 01:34:08 -0800 (PST) X-Gm-Message-State: AOAM531K6U4Pz/T2CG3GZQplToTbh/nZo/W2EWUFwx7iNrwMhobKsdkZ +nIq13nIr7vthMybEJHBToovOmPv2S6Tj5zW9+0= X-Google-Smtp-Source: ABdhPJzdWUmRHp4/lKLXv6+q2Thn0Sc0nr1QD99ZxxURYeZleIgI699G+WxW+sTjwSsYr4dfIETXbVshldOB36R2nMg= X-Received: by 2002:a9d:6b8b:: with SMTP id b11mr2798119otq.210.1614850447259; Thu, 04 Mar 2021 01:34:07 -0800 (PST) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-5-brad@pensando.io> In-Reply-To: <20210304034141.7062-5-brad@pensando.io> From: Arnd Bergmann Date: Thu, 4 Mar 2021 10:33:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/8] spidev: Add Pensando CPLD compatible To: Brad Larson Cc: Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:seRvg0yhGSVe9OKFJx/AdzC6Z6J8W7Yhhtv/pNsPzHNCOpa2R8R pTnmKCxJLaq3piXSLbEnZz7mAd0jrIaqYbktGLZIaFX8EnXHi9blsl854kTWlCfaAxnCjrq jmmA1KZ55lEIR4Vrmynv6H9fFTgvgj2eecHwhMXNEvpANqv9IDV2IhqodpAFs8kKNV+EmPx inae/8YJeTb6T6VIgX+tQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:3JkiklS7VkA=:JoShOBsLn/zRSJOhd3kGMH +W+e8xEZ/rGtTFkcsHuoCYTRpHai47x2AgPTZ4q/VFJMsgIDfJwhBGaZAI8ZqSFGfmIh+drD7 xQmkCMKOeMyVNELSR6vYcr9P39qsaWDQu2WsPumzan5UNnRmBCdiIK9XswCe4I5yqhhBD0KTk mEauzZ7k398LG7O6CByBeUfFJEPqiRB8v2mLrkS9jkPE1dw9ZFVWw6t+nnE8RqNh9fROLcwgl +J/7LsPASVnJNecoHsCLv3m3YkYcFWZldgA7BgcsQDlyv5cir77p6/qCn2ZpsFLeTlHoif32m BQTbgf55gNmWDhrs0YmEatIAPtCRuMvBxQ2br6PllQWwqdMPzrIH0l5a1GJSQ3B/AILVg+6rD nXmLsaNzvY2oRZIDK8trqA+GwfKoXiPLdOC9zUlouOxX8ymWOLExvXmVGiFJt6YDdPpmy+7Iu LW5yk53WfbN+UbiHTyQoLZXvsGAAWmWQF6wmamqhkJNwnEinWTDoOypW0nOnyIQ/pBNRv2f/l D5hYetov2nd1exf9wJR/vM1Qi3vFPgSxROGjmxoQurZSBwnS7OKR+TyRsgqXJzpwg== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 4, 2021 at 4:41 AM Brad Larson wrote: > > Pensando Elba SoC platforms have a SPI connected CPLD > for platform management. > > Signed-off-by: Brad Larson > --- > drivers/spi/spidev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c > index 8cb4d923aeaa..8b285852ce82 100644 > --- a/drivers/spi/spidev.c > +++ b/drivers/spi/spidev.c > @@ -683,6 +683,7 @@ static const struct of_device_id spidev_dt_ids[] = { > { .compatible = "dh,dhcom-board" }, > { .compatible = "menlo,m53cpld" }, > { .compatible = "cisco,spi-petra" }, > + { .compatible = "pensando,cpld" }, > {}, > }; This does not seem appropriate, I think a platform management driver should have a proper kernel abstraction instead of a user passthrough. As mentioned elsewhere, it also needs to be way more specific. If this is a programmable block, the compatible string might in fact need to contain both a board identifier and a revision number for the programmable logic, to ensure that the driver knows how to talk to it. Arnd