From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4222BC4320A for ; Fri, 23 Jul 2021 18:40:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25DCE60F22 for ; Fri, 23 Jul 2021 18:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbhGWSAF (ORCPT ); Fri, 23 Jul 2021 14:00:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:36042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbhGWSAE (ORCPT ); Fri, 23 Jul 2021 14:00:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DB85460F35 for ; Fri, 23 Jul 2021 18:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627065637; bh=luXtGcA9XPkn2pKeuXVILcPOHo+qWZTOu992ZyXafQg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=N83j4dx3rfgzlrRme4TcsorPA3CwCjlYZTPM33Jyuu5g1ZFvrbAHK2bAaJG+hdmG0 hw4wiFRurvy5qLdIXD/jJMuUTRK55/Zyq1SHsITZ1PxD/nANq7uea7MJeEe4jJGklt RScFbpJrFaNHDHSC0ibEy3+SX+3454CDR5eai2/u+EzZIZKAUyRrt/FWB+HWCSjBWR 3fNyj1im4apMuZSUXjAjCj0uGL3hPloYHnxqhVBBxc7UR21uRr9wy1tDCgeJAltvT0 oVvrJo3YOpzgXI2lpBpYGicBY+ir8bpx/qrVBXlHs3/VacQ/0dOuS+AFXQX5oBVVco GdQN4tYxbg/0g== Received: by mail-wr1-f51.google.com with SMTP id o1so3348299wrp.5 for ; Fri, 23 Jul 2021 11:40:37 -0700 (PDT) X-Gm-Message-State: AOAM531iy/wJ9TJUvl2ThBwZKX2ZlvaBp40387HAultsncqLpzgA31yR NKkJGA8bRkREwAaFChsVSz44ytrBPORQ36zBq7E= X-Google-Smtp-Source: ABdhPJwMCndPGt5XAO6Dm7un4OXszpJWIOXjaITxEdSd5iU9hBRvRdKTCo042U0vc2Fd3fqthaHa2RFxAK6soz4ZCx0= X-Received: by 2002:a5d:65cb:: with SMTP id e11mr6959840wrw.105.1627065636499; Fri, 23 Jul 2021 11:40:36 -0700 (PDT) MIME-Version: 1.0 References: <20210723091534.1730564-1-arnd@kernel.org> <7ddd0c7c-9bdc-9ea3-c635-f1d141d1e870@infradead.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 23 Jul 2021 20:40:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n To: Karol Herbst Cc: Randy Dunlap , Ben Skeggs , David Airlie , Daniel Vetter , Lyude Paul , Arnd Bergmann , nouveau , LKML , dri-devel , Nikola Cornij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote: > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > > > > > > what's actually the use case of compiling with > > > CONFIG_DRM_NOUVEAU_BACKLIGHT=n anyway? > > > > Dunno. In this case it was just a randconfig. Still, it needs to be > > handled in some way - such as the other suggestion in this thread. > > > > sure, I was just curious if there was a specific use case or just > something random as you mentioned. I think this is purely done because of tradition. A long time ago, we had tiny framebuffer drivers and most PCs did not have backlights, so it made sense to leave this optional. This was probably just always carried over. Arnd