From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751766AbdFHI7p (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Jun 2017 04:59:45 -0400
Received: from mail-oi0-f65.google.com ([209.85.218.65]:35088 "EHLO
        mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750725AbdFHI7o (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Jun 2017 04:59:44 -0400
MIME-Version: 1.0
In-Reply-To: <CAK8P3a3SOYmCstytN31sSr55GCfrX9avTkKAtohamuVrROFxAA@mail.gmail.com>
References: <20170530181306.GV141096@google.com> <20170531235519.GX141096@google.com>
 <CAK8P3a3nrxvTVx8zjgf+_byAX82FG8jFD73L2nPSJBwK5grdXA@mail.gmail.com>
 <CA+55aFyhgWGr-=9t7131XAUyNy8Zs_vUfp-PGu_eaLkMAa6=sg@mail.gmail.com>
 <20170606212354.GZ141096@google.com> <CA+55aFzzcz9p7c_VS2JDd-1735Yfb8Mgu6YJTYnFAY2KSiW5gA@mail.gmail.com>
 <CAK8P3a3SOYmCstytN31sSr55GCfrX9avTkKAtohamuVrROFxAA@mail.gmail.com>
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 8 Jun 2017 10:59:43 +0200
X-Google-Sender-Auth: cR_1GIbTojVjOElXIlGGJn1C6p0
Message-ID: <CAK8P3a0Ys1ONq+F1Wu50G1XV9phRkiZrnO5DxX6ELJM20kh0ZA@mail.gmail.com>
Subject: Re: [RFC] clang: 'unused-function' warning on static inline functions
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Steven Rostedt <rostedt@goodmis.org>,
        David Rientjes <rientjes@google.com>,
        Douglas Anderson <dianders@chromium.org>,
        Guenter Roeck <linux@roeck-us.net>, Mark Brown <broonie@kernel.org>,
        David Miller <davem@davemloft.net>, Tom Herbert <tom@herbertland.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 7, 2017 at 9:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jun 6, 2017 at 11:28 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:

> I even found one function that should be called but is not:
> __ila_hash_secret_init(). This one might be a serious bug,
> or it might be harmless.
>
>  [Adding Tom Herbert to Cc here, Tom, please have a look
> at net/ipv6/ila/ila_xlat.c for the missing initialization of hashrnd]

I submitted a patch for this one now, and another one for a function
in kernel/cpu.c that was obviously meant to be removed not too long
ago. I checked that all other instances of the warning I found in the
kernel are indeed harmless and don't need a patch when there is
no warning.

       Arnd