From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Rob Landley <rob@landley.net>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: use the generic dma-noncoherent code for sh V2
Date: Tue, 31 Jul 2018 15:25:46 +0200 [thread overview]
Message-ID: <CAK8P3a0ZsU=qKhA2ux0X1Zqo0aD6d9T8wnwc5Kr9T6wbsGp2fw@mail.gmail.com> (raw)
In-Reply-To: <20180730090648.GA18361@lst.de>
On Mon, Jul 30, 2018 at 11:06 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, Jul 27, 2018 at 11:20:21AM -0500, Rob Landley wrote:
>> Speaking of DMA:
>
> Which really has nothing to do with the dma mapping code, which
> also means I can't help you much unfortunately.
>
> That being said sh is the last pending of the initial dma-noncoherent
> conversion, I'd greatly appreciate if we could get this reviewed and
> merge for the 4.19 merge window..
I've spent 30 minutes looking through your submission to find something
wrong with it now, but it all looks fine, the only criticism would be that
some of the changelogs could provide a little more background.
The original implementation seems odd in some places, but your
new version resolves the few concerns I had (like mixing up
phys and dma addresses), and I didn't see anything that should
change behavior.
I hope that helps.
Arnd
next prev parent reply other threads:[~2018-07-31 13:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 12:01 use the generic dma-noncoherent code for sh V2 Christoph Hellwig
2018-07-24 12:01 ` [PATCH 1/5] sh: simplify get_arch_dma_ops Christoph Hellwig
2018-07-24 12:01 ` [PATCH 2/5] sh: introduce a sh_cacheop_vaddr helper Christoph Hellwig
2018-07-24 12:01 ` [PATCH 3/5] sh: use dma_direct_ops for the CONFIG_DMA_COHERENT case Christoph Hellwig
2018-07-24 12:01 ` [PATCH 4/5] sh: split arch/sh/mm/consistent.c Christoph Hellwig
2018-07-24 12:01 ` [PATCH 5/5] sh: use generic dma_noncoherent_ops Christoph Hellwig
2018-07-24 20:21 ` use the generic dma-noncoherent code for sh V2 Christoph Hellwig
2018-07-27 16:20 ` Rob Landley
2018-07-30 9:06 ` Christoph Hellwig
2018-07-31 13:25 ` Arnd Bergmann [this message]
2018-07-30 9:24 ` Geert Uytterhoeven
2018-07-31 12:56 ` Arnd Bergmann
2018-08-17 17:04 ` dmaengine for sh7760 (was Re: use the generic dma-noncoherent code for sh V2) Rob Landley
2018-08-17 20:23 ` Arnd Bergmann
2018-08-19 5:38 ` Rob Landley
2018-08-20 12:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0ZsU=qKhA2ux0X1Zqo0aD6d9T8wnwc5Kr9T6wbsGp2fw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rob@landley.net \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).