From: Arnd Bergmann <arnd@arndb.de>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Alexandre Ghiti <alex@ghiti.fr>, Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
DTML <devicetree@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -fixes] riscv: Fix BUILTIN_DTB for sifive and microchip soc
Date: Fri, 4 Jun 2021 20:34:53 +0200 [thread overview]
Message-ID: <CAK8P3a0fsYwMOioFd7UqzVT0oDSKAA=cjo2o781juO1v88sLAw@mail.gmail.com> (raw)
In-Reply-To: <mhng-f1a76f5f-ad66-40ae-aad3-cd2f669f33bf@palmerdabbelt-glaptop>
On Fri, Jun 4, 2021 at 5:51 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
> On Fri, 04 Jun 2021 06:08:05 PDT (-0700), Arnd Bergmann wrote:
> > On Fri, Jun 4, 2021 at 2:06 PM Alexandre Ghiti <alex@ghiti.fr> wrote:
> >>
> >> Fix BUILTIN_DTB config which resulted in a dtb that was actually not built
> >> into the Linux image: in the same manner as Canaan soc does, create an object
> >> file from the dtb file that will get linked into the Linux image.
> >>
> >> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
> >
> > Along the same lines as the comment that Jisheng Zhang made on the fixed
> > address, building a dtb into the kernel itself fundamentally breaks generic
> > kernel images.
> >
> > I can understand using it on K210, which is extremely limited and wouldn't
> > run a generic kernel anyway, but for normal platforms like microchip and
> > sifive, it would be better to disallow CONFIG_BUILTIN_DTB in Kconfig
> > and require a non-broken boot loader.
>
> When we first added BUILTIN_DTB we actually had a compatibility
> mechanism in there. There isn't enough in the ISA to handle board
> compatibility, but we were hoping to get something to deal with that.
> It didn't pan out so we dropped the compatibility mechanism, which is
> how we ended up here.
>
> Maybe the right thing to do here is to add some sort of "be compatible
> with the platform spec" Kconfig, which we could then use to disallow all
> these features that result in non-portable kernels?
Yes, I should have read your email before I replied with the same
suggestion to Vitaly ;-)
Arnd
next prev parent reply other threads:[~2021-06-04 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 12:06 [PATCH -fixes] riscv: Fix BUILTIN_DTB for sifive and microchip soc Alexandre Ghiti
2021-06-04 13:08 ` Arnd Bergmann
2021-06-04 15:51 ` Palmer Dabbelt
2021-06-04 18:34 ` Arnd Bergmann [this message]
2021-06-04 17:45 ` Vitaly Wool
2021-06-04 18:33 ` Arnd Bergmann
2021-06-05 6:33 ` Alex Ghiti
2021-06-05 11:00 ` Arnd Bergmann
2021-06-06 7:40 ` Alex Ghiti
2021-06-12 4:10 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0fsYwMOioFd7UqzVT0oDSKAA=cjo2o781juO1v88sLAw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).