From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E309C28CC3 for ; Fri, 31 May 2019 08:32:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60FF424353 for ; Fri, 31 May 2019 08:32:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbfEaIck (ORCPT ); Fri, 31 May 2019 04:32:40 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46086 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfEaIcj (ORCPT ); Fri, 31 May 2019 04:32:39 -0400 Received: by mail-qt1-f195.google.com with SMTP id z19so10334793qtz.13; Fri, 31 May 2019 01:32:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=igjuJGXMsnGZDhorJwfUv0+nOH3lmOMpPh5Fkg034nY=; b=uQzHWqI/4n7WQG8Knyd+6VFA9p/5C2AoVmmzMD3u/8Bsbt1DRPul91CW4nlDvBUOOJ D9NoAfnBj9XykWe7CYVyo/eyaqWW6tyKl9hYNKXSIiAS3KS1gSnW4+AnEuJ5RIA0ED1I /Zu8YLd457x8YKugDUghld9yALZW3fZ9e6ygQBsU6wLuj76tqZCyldWIBIcR3zxVRo/r j75DKKmtuQcHC9huDYCxJDaT4xC3zUvN9mFOOobFuFZ7ykz3OPJ7sECgZgEr2NV5GG/n lYX6WAcJhzmnwYlBG/yFhIBXeui3m78mpObwmGqftm3a0bpI93787Fd0o6RlF2hy3xR6 8r5A== X-Gm-Message-State: APjAAAWHbibYO0xBA6Y8g2dRbg4BM0anSwitaigTcRspFY+MepoIRyKe YmGeOpdh2IIS/kP0VbnjY3aLf00WyhoQmGr23rs= X-Google-Smtp-Source: APXvYqz9UY+8/pkIhfjqDnPdgHg65ZqG2L3gJyCnwOw2GV9Dc8VpZX9nAZNc7+rmbc0MPEHfPZRNJe3CE7OZS8hHUVo= X-Received: by 2002:a0c:9e0f:: with SMTP id p15mr7572827qve.176.1559291558659; Fri, 31 May 2019 01:32:38 -0700 (PDT) MIME-Version: 1.0 References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-17-vincenzo.frascino@arm.com> In-Reply-To: <20190530141531.43462-17-vincenzo.frascino@arm.com> From: Arnd Bergmann Date: Fri, 31 May 2019 10:32:22 +0200 Message-ID: Subject: Re: [PATCH v6 16/19] arm: Add support for generic vDSO To: Vincenzo Frascino Cc: linux-arch , Linux ARM , Linux Kernel Mailing List , linux-mips@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino wrote: > diff --git a/arch/arm/include/asm/vdso/gettimeofday.h b/arch/arm/include/asm/vdso/gettimeofday.h > new file mode 100644 > index 000000000000..eeeb319840ba > --- /dev/null > +++ b/arch/arm/include/asm/vdso/gettimeofday.h > @@ -0,0 +1,96 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2018 ARM Limited > + */ > +#ifndef __ASM_VDSO_GETTIMEOFDAY_H > +#define __ASM_VDSO_GETTIMEOFDAY_H > + > +#ifndef __ASSEMBLY__ > + > +#include > +#include > +#include > +#include > + > +#ifndef CONFIG_AEABI > +#error This code depends on AEABI system call conventions > +#endif Instead of an #error here, I would use a Kconfig conditional and make it 'select HAVE_GENERIC_VDSO if AEABI' > diff --git a/arch/arm/vdso/vdso.lds.S b/arch/arm/vdso/vdso.lds.S > index 89ca89f12d23..05581140fd12 100644 > --- a/arch/arm/vdso/vdso.lds.S > +++ b/arch/arm/vdso/vdso.lds.S > @@ -82,6 +82,8 @@ VERSION > global: > __vdso_clock_gettime; > __vdso_gettimeofday; > + __vdso_clock_getres; > + __vdso_clock_gettime64; > local: *; > }; Why are you adding __vdso_clock_getres here? I would probably leave the addition of the new entry point(s) for a separate patch at the end, adding __vdso_clock_gettime64 to all 32-bit ABIs at once, since while that part is a trivial change, it's also user visible and deserves its own changelog text. Arnd