archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <>
To: Leon Romanovsky <>
Cc: Saeed Mahameed <>,
	Matan Barak <>,
	"David S. Miller" <>,
	Erez Shitrit <>,
	Dan Carpenter <>,
	Stephen Hemminger <>,
	Networking <>,,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH net-next] mlx5: work around unused function warning
Date: Thu, 27 Apr 2017 14:04:15 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20170427115513.GH14088@mtr-leonro.local>

On Thu, Apr 27, 2017 at 1:55 PM, Leon Romanovsky <> wrote:
> On Thu, Apr 27, 2017 at 01:04:02PM +0200, Arnd Bergmann wrote:
>> The previous patch addressed a sparse warning but replaced it with a
>> compiler warning when CONFIG_MODULES is disabled:
>> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:485:13: error: 'mlx5_rdma_netdev_free' defined but not used [-Werror=unused-function]
>> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:423:27: error: 'mlx5_rdma_netdev_alloc' defined but not used [-Werror=unused-function]
>> We should never export 'static' functions, so this makes them global
>> again but hides them in another #ifdef like the change before.
>> Fixes: a7082ef066f0 ("mlx5: hide unused functions")
>> Signed-off-by: Arnd Bergmann <>
> Hi Arnd,
> Thanks for the patch, but Stephen and Saeed already sent patch similar to it.

That link is for the patch that introduced the warning that I'm fixing here,
it showed up yesterday in linux-next.

Did you misread my patch, or just give the wrong link?


  reply	other threads:[~2017-04-27 12:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 11:04 [PATCH net-next] mlx5: work around unused function warning Arnd Bergmann
2017-04-27 11:55 ` Leon Romanovsky
2017-04-27 12:04   ` Arnd Bergmann [this message]
2017-04-27 13:13     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).