From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753108AbdHGL6b (ORCPT ); Mon, 7 Aug 2017 07:58:31 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:37224 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbdHGL6a (ORCPT ); Mon, 7 Aug 2017 07:58:30 -0400 MIME-Version: 1.0 In-Reply-To: <20170807114837.3bqsroayi3sipf4h@sirena.org.uk> References: <20170807104101.3540159-1-arnd@arndb.de> <20170807112030.zvz3flujilsixdj4@sirena.org.uk> <20170807114837.3bqsroayi3sipf4h@sirena.org.uk> From: Arnd Bergmann Date: Mon, 7 Aug 2017 13:58:29 +0200 X-Google-Sender-Auth: 8tVlzt_WT3e8YUFRiickijE2Fmc Message-ID: Subject: Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing To: Mark Brown Cc: Liam Girdwood , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Linux ARM , alsa-devel@alsa-project.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 7, 2017 at 1:48 PM, Mark Brown wrote: > On Mon, Aug 07, 2017 at 01:36:09PM +0200, Arnd Bergmann wrote: >> On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown wrote: >> > On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote: >> >> When the audio driver selects CONFIG_PXA_SSP to be a loadable >> >> module on a platform other than PXA, and the PXA SPI driver >> >> is built-in, we get a link error in the SPI driver: > >> > Why doesn't this cause problems on PXA? > >> On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o >> is located. On other ARM platforms (I guess except for MMP), >> PLAT_PXA is not set, and on non-ARM architectures, we can't >> get there anyway. > > Still missing a few steps of reasoning here... Sorry, I just realized that you were trying to point out the incomplete changelog. I must have accidentally closed the editor while working on it, and then sent it out today after getting no regressions. I'll resend with a proper changelog. Arnd