From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757449AbdJMHmt (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Oct 2017 03:42:49 -0400
Received: from mail-oi0-f66.google.com ([209.85.218.66]:33127 "EHLO
        mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753135AbdJMHmr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Oct 2017 03:42:47 -0400
X-Google-Smtp-Source: ABhQp+SmdRDyl/nLY4gwT/DTV4CS2R6Er+PELYu4yy1T0hv4AVE+0fgsgbj4A95Ue7PZvXyvHqeoXtgjVLHZ3HvnOw0=
MIME-Version: 1.0
In-Reply-To: <1507827914.16112.449.camel@linux.intel.com>
References: <20170608134811.60786-1-andriy.shevchenko@linux.intel.com>
 <20170608134811.60786-25-andriy.shevchenko@linux.intel.com>
 <CAK8P3a3RNAty5T8nR2F3JMJB2zYyeJQ0qvj0gJxa0QB57TcVuQ@mail.gmail.com> <1507827914.16112.449.camel@linux.intel.com>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 13 Oct 2017 09:42:46 +0200
X-Google-Sender-Auth: 5jBr5CwpSMHyA0cEidL7_jY-ud0
Message-ID: <CAK8P3a18OJgyA-wePsUCk+H2_3eA5AqoMNBSN3QQL0ki9mGHEw@mail.gmail.com>
Subject: Re: [PATCH v1 24/25] kdb: Switch to use %pt
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        linux-rtc@vger.kernel.org, Jason Wessel <jason.wessel@windriver.com>,
        Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 12, 2017 at 7:05 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Thu, 2017-10-12 at 15:31 +0200, Arnd Bergmann wrote:
>> On Thu, Jun 8, 2017 at 3:48 PM, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>
>> > diff --git a/kernel/debug/kdb/kdb_main.c
>> > b/kernel/debug/kdb/kdb_main.c
>> > index c8146d53ca67..2a6f12be79d8 100644
>> > --- a/kernel/debug/kdb/kdb_main.c
>> > +++ b/kernel/debug/kdb/kdb_main.c
>> > @@ -2556,12 +2556,7 @@ static int kdb_summary(int argc, const char
>> > **argv)
>> >
>> >         now = __current_kernel_time();
>> >         kdb_gmtime(&now, &tm);
>> > -       kdb_printf("date       %04d-%02d-%02d %02d:%02d:%02d "
>> > -                  "tz_minuteswest %d\n",
>> > -               1900+tm.tm_year, tm.tm_mon+1, tm.tm_mday,
>> > -               tm.tm_hour, tm.tm_min, tm.tm_sec,
>> > -               sys_tz.tz_minuteswest);
>> > -
>>
>> I just experimented with a similar change and noticed your version.
>>
>> You forgot to remove the kdb_gmtime() function that is now completely
>> unneeded. My patch takes care of that now.
>
> So, are you going to substitute entire series by your variant?
>
> What did you choose to be format for the %p extension?

My patch doesn't touch printf at all, instead it removes the
__current_kernel_time() function, so it's unrelated but happens
to change the same lines here. Since kdb_gmtime() doesn't
work with 64-bit time_t, I replaced it using the generic
time64_to_tm() helper and removed it here.

       Arnd