From: Arnd Bergmann <arnd@arndb.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: SH: error: implicit declaration of function 'init_cache_node_node'
Date: Sun, 14 Nov 2021 23:04:53 +0100 [thread overview]
Message-ID: <CAK8P3a1FcP8R1stLEj4468kk_zF28rCQz7mZZhVk31r-jYpYcg@mail.gmail.com> (raw)
In-Reply-To: <b5bdea22-ed2f-3187-6efe-0c72330270a4@infradead.org>
On Sun, Nov 14, 2021 at 2:17 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on arch/sh/,
> CONFIG_SMP is not defined,
> CONFIG_NUMA=y,
> CONFIG_MEMORY_HOTPLUG is not defined:
>
> ../mm/slab.c: In function 'slab_memory_callback':
> ../mm/slab.c:1143:23: error: implicit declaration of function 'init_cache_node_node'; did you mean 'drain_cache_node_node'? [-Werror=implicit-function-declaration]
> 1143 | ret = init_cache_node_node(nid);
>
>
> commit 76af6a054da4
> Author: Dave Hansen <dave.hansen@linux.intel.com>
> Date: Mon Oct 18 15:15:32 2021 -0700
>
> mm/migrate: add CPU hotplug to demotion #ifdef
>
>
> How should we handle this config?
I think we can safely assume that NUMA without SMP is not a useful
configuration on SH and add a dependency in Kconfig for it.
I assume this came from some randconfig build rather than a config
that someone was intentionally using? My guess would be that testing
sh randconfig kernels is not overly productive as you likely need
countless patches before there is a chance of it working most of
the time. I haven't tried this myself, but I spend a lot of time fixing
randconfig failures on arm and x86, and I whenever I try any other
architecture, there is simply too much work needed upfront.
Arnd
next prev parent reply other threads:[~2021-11-14 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 1:17 SH: error: implicit declaration of function 'init_cache_node_node' Randy Dunlap
2021-11-14 22:04 ` Arnd Bergmann [this message]
2021-11-14 22:19 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1FcP8R1stLEj4468kk_zF28rCQz7mZZhVk31r-jYpYcg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@infradead.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).