From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F3CFC4741F for ; Thu, 5 Nov 2020 09:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2934F2222C for ; Thu, 5 Nov 2020 09:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604569750; bh=QBR2Tc/9WNzTItkRBAt9IIJdb9EsfXRdlj3TCpicmg4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=HakcXH6qst/GwkqsdyeWJceDfOQZ0pzveiYNvwK+8VgRD+s6pd810bIf2WvnUr43P sbEfNfvejl4C90cRaASLDiJRUnq25d1CwJuXAgjwSSvadhyMnuxSRhD56EpxzI+Eqg AEfbWo5B7q2zoCQVUm5GWKtDWTOnyAgnJRli286c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727968AbgKEJtJ (ORCPT ); Thu, 5 Nov 2020 04:49:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:35112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725308AbgKEJtI (ORCPT ); Thu, 5 Nov 2020 04:49:08 -0500 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5EFCD21D46; Thu, 5 Nov 2020 09:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604569747; bh=QBR2Tc/9WNzTItkRBAt9IIJdb9EsfXRdlj3TCpicmg4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ux2MHWMezbdTAo81cgm1ldp+hleWgwwW1SttCwLqTfOlLCiDBDKGSSfYGNkaM0b9W M2JupBXyoHhxYXzW4mcmGnlFXoLNCg0oyI1Rf3AztWdDhXWtRgPj3RRDyj/cUmewRf TSxUIaP7q7NvhBXJ4p1LHOsMpauLbRD8w0dxGTsE= Received: by mail-wm1-f50.google.com with SMTP id h62so922745wme.3; Thu, 05 Nov 2020 01:49:07 -0800 (PST) X-Gm-Message-State: AOAM5337p3gXvOPcsVILJyqjg8RZoj4NEyC0l6XdqCVSpgGz3Jgoo/A/ N+cQzK1MgDaFuzNbcl9cHQiJUDxwzuimyi8G/hQ= X-Google-Smtp-Source: ABdhPJwAVTDv6MUiz/sUTWF6rT7rByTwI3xxgju//qMYNu5dRGzqQlZc8Ge4oUCahSSPXmbn6Zo+Hvxg4DXvv4ReSCQ= X-Received: by 2002:a1c:b746:: with SMTP id h67mr1726797wmf.43.1604569745838; Thu, 05 Nov 2020 01:49:05 -0800 (PST) MIME-Version: 1.0 References: <20200930105442.3f642f6c@aktux> <20200930164446.GB219887@roeck-us.net> <20201002002251.28462e64@aktux> <7543ef85-727d-96c3-947e-5b18e9e6c44d@roeck-us.net> <20201006090226.4275c824@kemnade.info> <68467f1b-cea1-47ea-a4d4-8319214b072a@fnarfbargle.com> <20201104142057.62493c12@aktux> <2436afef-99c6-c352-936d-567bf553388c@fnarfbargle.com> <7a085650-2399-08c0-3c4d-6cd1fa28a365@roeck-us.net> In-Reply-To: From: Arnd Bergmann Date: Thu, 5 Nov 2020 10:48:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay() To: Brad Campbell Cc: Guenter Roeck , Andreas Kemnade , Jean Delvare , Arnd Bergmann , rydberg@bitmath.org, linux-hwmon@vger.kernel.org, "linux-kernel@vger.kernel.org" , "H. Nikolaus Schaller" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 5, 2020 at 6:05 AM Brad Campbell wrote: > Appreciate the feedback. > > This would be the bare minimum based on the bits use in the original code. If the original code worked "well enough" then this should be relatively safe. > > Tested on both machines I have access to. For the patch: Acked-by: Arnd Bergmann I'm glad you figured out something that works. This all looks reasonable and it makes much more sense than the original version that I tried to clean up just based on the code comments but without having access to hardware or documentation. Arnd