From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdFFJDx (ORCPT ); Tue, 6 Jun 2017 05:03:53 -0400 Received: from mail-ot0-f193.google.com ([74.125.82.193]:34641 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdFFJDw (ORCPT ); Tue, 6 Jun 2017 05:03:52 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Arnd Bergmann Date: Tue, 6 Jun 2017 11:03:51 +0200 X-Google-Sender-Auth: E6NgsId35_m4j_LpoMVv53fdyvM Message-ID: Subject: Re: [PATCH 6/7] RISC-V: arch/riscv/kernel To: Palmer Dabbelt Cc: Olof Johansson , Linux Kernel Mailing List , albert@sifive.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: > On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: >> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >>> On Mon, 22 May 2017 19:11:35 PDT (-0700), olof@lixom.net wrote: >> >>> * Definitions like ARCH_HAS_SETUP_ADDITIONAL_PAGES, these are also present in >>> other architectures. >> >> What is the warning here? I would assume that you should leave this >> unchanged as well. > > ERROR: #define of 'ARCH_HAS_SETUP_ADDITIONAL_PAGES' is wrong - use Kconfig variables or standard guards instead > #2533: FILE: arch/riscv/include/asm/elf.h:79: > +#define ARCH_HAS_SETUP_ADDITIONAL_PAGES Ok, you can definitely ignore this one. The warning is meant to prevent adding new macros like that, but the macro already exists in the other architectures, and I see no point in converting them all into a CONFIG_ symbol. Arnd