From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E766C433FF for ; Fri, 9 Aug 2019 11:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58B6B2086D for ; Fri, 9 Aug 2019 11:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406054AbfHILXl (ORCPT ); Fri, 9 Aug 2019 07:23:41 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:43210 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726152AbfHILXk (ORCPT ); Fri, 9 Aug 2019 07:23:40 -0400 Received: by mail-qt1-f193.google.com with SMTP id w17so14770656qto.10; Fri, 09 Aug 2019 04:23:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gRvZxPuek6JRQruqkUJVQMjk/VZ8xO7dmw6h4WlzFd8=; b=WuaD4yAT13VVQavIIanPYMWs5+oqp9KI29Q+xHlYVB7kU1d3Zww6FUKKWuzIx+8Ktl yFhaN69ky24Y+DsAc/997F3Xl3ggb4Wb5Dd2/mk1RhiuEChJfypa9YPl0vS/y6eB+2Se tfQ181d5FukxVH1ASnDRfBSxV3SrXHjKPqv3Wgv0XatKegTLK4Z/Hku3xpysOjWMxTer 2ftZ0PYk9on7TntwuR2xA9cKHJJcBW03NRnEfOXVxDErysGr9GBcqou102NSjouL4td/ sIqb3ekeKlBEGRZgodiMOImiOGmsUgMRfblRrq/XJdd+zH/ckKW4ZnwuuvB9qSOzWr63 gzYg== X-Gm-Message-State: APjAAAWwrlx+lQ20E8NqbfqMQZA0AuztnVm6ZDx0IgJcQC0vY+6vN5Pd jpXZjC7siOENGeQgOWEgVHmXRss/iMgo1GmvfMU= X-Google-Smtp-Source: APXvYqwyfun0rS3dI0VPy9YQLTjb23p3p5REd7rS9TuRRKEk5l8WvDyNNaWtDch5+OMsqDgqQyJPBtXPE6lfaVR0VOI= X-Received: by 2002:ac8:5311:: with SMTP id t17mr17162360qtn.304.1565349819769; Fri, 09 Aug 2019 04:23:39 -0700 (PDT) MIME-Version: 1.0 References: <20190808212234.2213262-1-arnd@arndb.de> <20190808212234.2213262-14-arnd@arndb.de> <20190808214257.GF178933@dtor-ws> <20190808221950.GG178933@dtor-ws> <20190808233941.v6elo2mdji5awylu@earth.universe> In-Reply-To: <20190808233941.v6elo2mdji5awylu@earth.universe> From: Arnd Bergmann Date: Fri, 9 Aug 2019 13:23:23 +0200 Message-ID: Subject: Re: [PATCH 13/22] input: omap: void using mach/*.h headers To: Sebastian Reichel Cc: Dmitry Torokhov , Aaro Koskinen , Tony Lindgren , Greg Kroah-Hartman , Linus Walleij , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , Tomi Valkeinen , "open list:HID CORE LAYER" , linux-omap , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 9, 2019 at 1:39 AM Sebastian Reichel wrote: > On Thu, Aug 08, 2019 at 03:19:50PM -0700, Dmitry Torokhov wrote: > > On Thu, Aug 08, 2019 at 11:46:45PM +0200, Arnd Bergmann wrote: > > > On Thu, Aug 8, 2019 at 11:43 PM Dmitry Torokhov wrote: > > > > On Thu, Aug 08, 2019 at 11:22:22PM +0200, Arnd Bergmann wrote: > > > > > By using the new linux/soc/ti/omap1-io.h header instead, > > > > > compile-testing can be enabled, and a CONFIG_ARCH_MULTIPLATFORM > > > > > conversion of omap1 may eventually be possible. > > > > > > > > > > The warning in the header file gets removed in order to > > > > > allow CONFIG_COMPILE_TEST. > > > > > > > > Given that we want to migrate people off this driver everywhere but > > > > OMAP1 I wonder why we would want to improve compile coverage of it. > > > > > > Mainly for consistency: I'm converting all omap1 drivers in this series to > > > not rely on mach/* headers and to let them be compiled standalone. > > > The other drivers don't have a replacement, so I could treat this different > > > from the rest and skip the Kconfig and platform_data changes if you > > > prefer. > > > > Yes, because at least with the version you posted we are losing the > > #warning telling people to move to matrix_keypad. We could do: > > > > #ifndef CONFIG_COMPILE_TEST > > #warning ... > > #endif > > > > if you really want to allow compiling standalone for testing. No, I'll just drop the compile-test portion and leave the warning untouched, leaving only the header file include as a preparation for multiplatform support then. > FWIW the driver depends on ARCH_OMAP1 and the warning is > only printed for !ARCH_OMAP1. In other words: The warning > is never printed at the moment. All OMAP2+ boards moved to > matrix-keypad long time ago and the driver does not support > OMAP2+ anymore since f799a3d8fe170 from 2012. Right, it also seems extremely unlikely that any new platform would start using the header, and it also doesn't look like anyone is interested in moving omap1 over to matrix-keypad. Arnd