From: Arnd Bergmann <arnd@arndb.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
Linux API <linux-api@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Paul Eggert <eggert@cs.ucla.edu>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-alpha@vger.kernel.org,
Deepa Dinamani <deepa.kernel@gmail.com>
Subject: Re: [PATCH v2 2/2] rusage: allow 64-bit times ru_utime/ru_stime
Date: Thu, 21 Jun 2018 18:01:24 +0200 [thread overview]
Message-ID: <CAK8P3a1QYTfRNQt2+a29BpvgYM_pnSFrO=NBvVo=BdUa2q9ngQ@mail.gmail.com> (raw)
In-Reply-To: <20180621154915.GA31947@gmail.com>
On Thu, Jun 21, 2018 at 5:49 PM, Ingo Molnar <mingo@kernel.org> wrote:
> * Arnd Bergmann <arnd@arndb.de> wrote:
>
>> +int put_compat_rusage_time64(const struct __kernel_rusage *r,
>> + struct compat_rusage_time64 __user *ru)
>> +{
>> + struct compat_rusage_time64 r32;
>> + memset(&r32, 0, sizeof(r32));
>> + r32.ru_utime.tv_sec = r->ru_utime.tv_sec;
>> + r32.ru_utime.tv_usec = r->ru_utime.tv_usec;
>> + r32.ru_stime.tv_sec = r->ru_stime.tv_sec;
>> + r32.ru_stime.tv_usec = r->ru_stime.tv_usec;
>> + r32.ru_maxrss = r->ru_maxrss;
>> + r32.ru_ixrss = r->ru_ixrss;
>> + r32.ru_idrss = r->ru_idrss;
>> + r32.ru_isrss = r->ru_isrss;
>> + r32.ru_minflt = r->ru_minflt;
>> + r32.ru_majflt = r->ru_majflt;
>> + r32.ru_nswap = r->ru_nswap;
>> + r32.ru_inblock = r->ru_inblock;
>> + r32.ru_oublock = r->ru_oublock;
>> + r32.ru_msgsnd = r->ru_msgsnd;
>> + r32.ru_msgrcv = r->ru_msgrcv;
>> + r32.ru_nsignals = r->ru_nsignals;
>> + r32.ru_nvcsw = r->ru_nvcsw;
>> + r32.ru_nivcsw = r->ru_nivcsw;
>
> Could you please vertically align the right side of the initialization as well?
> Much easier to check at a glance.
...
> Which tabulated form made me notice the info.cause / si_code asymmetry - and a
> brief check of the source shows that it's correct. No way would I have noticed it
> in the jumbled up form above, so I think aligning such mass-initializations makes
> sense.
Sure, no problem. Do you have an opinion on the question I raised in the
first patch [1], i.e. whether we actually want this to be done this way in the
kernel, or one of the other approaches I described there?
Thanks for taking a look here already!
Arnd
[1] https://patchwork.kernel.org/patch/10352507/
next prev parent reply other threads:[~2018-06-21 16:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 12:05 [PATCH v2 1/2] y2038: rusage: Use __kernel_old_timeval for process times Arnd Bergmann
2018-04-20 12:05 ` [PATCH v2 2/2] rusage: allow 64-bit times ru_utime/ru_stime Arnd Bergmann
2018-06-21 15:49 ` Ingo Molnar
2018-06-21 16:01 ` Arnd Bergmann [this message]
2018-06-21 16:11 ` Ingo Molnar
2018-06-21 16:25 ` Arnd Bergmann
2018-06-22 2:16 ` Ingo Molnar
2018-06-22 17:45 ` Eric W. Biederman
2018-06-24 7:12 ` Ingo Molnar
2018-06-25 1:26 ` Eric W. Biederman
2018-06-25 9:14 ` Ingo Molnar
2018-06-25 16:21 ` Eric W. Biederman
2018-06-25 11:42 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1QYTfRNQt2+a29BpvgYM_pnSFrO=NBvVo=BdUa2q9ngQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=deepa.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=eggert@cs.ucla.edu \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mattst88@gmail.com \
--cc=mingo@kernel.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).