linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Anders Roxell <anders.roxell@linaro.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh@kernel.org>, DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency
Date: Mon, 23 Jul 2018 11:34:43 +0200	[thread overview]
Message-ID: <CAK8P3a1_8OSqyKsbw+m3ZzLWfPqDK4ynG3WoPTk+K2uJJsiq5A@mail.gmail.com> (raw)
In-Reply-To: <20180722082939.2de739f1@bbrezillon>

On Sun, Jul 22, 2018 at 8:29 AM, Boris Brezillon
<boris.brezillon@bootlin.com> wrote:
> +Arnd, Rob and the DT ML.
>
> On Sat, 21 Jul 2018 14:53:47 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
>> On 07/21/2018 01:00 PM, Anders Roxell wrote:
>> > JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this
>> > error:
>> > drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
>> > drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of
>> >  function ‘of_read_number’; did you mean ‘down_read_nested’?
>> >  [-Werror=implicit-function-declaration]
>> >    bank = of_read_number(prop, 1);
>> >           ^~~~~~~~~~~~~~
>> >           down_read_nested
>
> Looks like of.h defines stubs so that people can compile-test without
> CONFIG_OF selected. Maybe we should move of_read_number() and
> of_read_ulong() out of the #ifdef CONFIG_OF section.

That seems fine, though the added dependency seems appropriate
here as well. of_read_number() is rarely used, and for the most part in
powerpc specific code that is guaranteed to have CONFIG_OF enabled,
so it's not that likely to cause many more problems.

> Alternatively, we could patch jz4780-nemc.c to not use of_read_number
> and instead rely on of_read_property_u32_index() +
> of_property_count_elems_of_size() + of_n_{addr,size}_cells():

That seems noticeably longer for no good reason, I'd go with either
the header file change you suggested or Anders' patch.

       Arnd

  reply	other threads:[~2018-07-23  9:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 20:00 Anders Roxell
2018-07-21 21:53 ` Randy Dunlap
2018-07-22  6:29   ` Boris Brezillon
2018-07-23  9:34     ` Arnd Bergmann [this message]
2018-07-23  9:41       ` Boris Brezillon
2018-07-23 15:40         ` Arnd Bergmann
2018-07-23 16:04           ` Arnd Bergmann
2018-07-23 16:14             ` Boris Brezillon
2018-07-23 18:39               ` Arnd Bergmann
2018-07-23 16:12           ` Boris Brezillon
2018-07-26 23:25         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a1_8OSqyKsbw+m3ZzLWfPqDK4ynG3WoPTk+K2uJJsiq5A@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=anders.roxell@linaro.org \
    --cc=boris.brezillon@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --subject='Re: [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).