From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbdB1Ogu (ORCPT ); Tue, 28 Feb 2017 09:36:50 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:32843 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbdB1Ogt (ORCPT ); Tue, 28 Feb 2017 09:36:49 -0500 MIME-Version: 1.0 In-Reply-To: <1488287219-15832-4-git-send-email-geert@linux-m68k.org> References: <1488287219-15832-1-git-send-email-geert@linux-m68k.org> <1488287219-15832-4-git-send-email-geert@linux-m68k.org> From: Arnd Bergmann Date: Tue, 28 Feb 2017 15:28:35 +0100 X-Google-Sender-Auth: X1mlMB5E5b_QM_AWQjDY767uGZU Message-ID: Subject: Re: [PATCH 3/3] lib: add module support to linked list sorting tests To: Geert Uytterhoeven Cc: Andrew Morton , Andy Shevchenko , Paul Gortmaker , Shuah Khan , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 2:06 PM, Geert Uytterhoeven wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 90b2348777495b72..32363ae022e3282a 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1731,11 +1731,12 @@ config LKDTM > Documentation/fault-injection/provoke-crashes.txt > > config TEST_LIST_SORT > - bool "Linked list sorting test" > - depends on DEBUG_KERNEL > + tristate "Linked list sorting test" > + depends on DEBUG_KERNEL || m I don't see any other test code with a "DEBUG_KERNEL || m" dependency, but several that are "DEBUG_KERNEL && m". Maybe we should just force it to be a module like the others? If there are good reasons to have it built-in, I'd just drop the "|| m" here. Arnd