From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D62C4332F for ; Fri, 6 May 2022 07:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389477AbiEFHVq (ORCPT ); Fri, 6 May 2022 03:21:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352865AbiEFHVp (ORCPT ); Fri, 6 May 2022 03:21:45 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A827566FA3; Fri, 6 May 2022 00:18:02 -0700 (PDT) Received: from mail-wr1-f46.google.com ([209.85.221.46]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MtfVx-1o6BQU0OUh-00v8Wd; Fri, 06 May 2022 09:18:01 +0200 Received: by mail-wr1-f46.google.com with SMTP id j15so8825770wrb.2; Fri, 06 May 2022 00:18:01 -0700 (PDT) X-Gm-Message-State: AOAM530UXeyQH1I2fmrx7p793ELh0PDDWac3A8S6+5ZgUs+THa2G4Lef JqXFqiy95L2unMfzNajzPs9LhMYMIdm+nXa+4Kc= X-Google-Smtp-Source: ABdhPJxk5kmKl/NuJo2Kw6gbDMmUHBC9PzM37HJ0IpduByOSpYwlVh3nYidBN6G2ViFW9sJzR1YaV0REdELOtYll4hY= X-Received: by 2002:a5d:5986:0:b0:20c:5844:820d with SMTP id n6-20020a5d5986000000b0020c5844820dmr1472517wri.192.1651821480693; Fri, 06 May 2022 00:18:00 -0700 (PDT) MIME-Version: 1.0 References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 6 May 2022 09:17:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings To: Philip Li Cc: Dave Hansen , Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:uuYCo+mphVTnNPmhY2lL8Z/svpjDh2VmUZwvOUg2KeF6q7B2hR6 ahh2Wi2f44fThQPEpHBS1G10VRuffKDpyJVvBJtMQAUoDq14lcymApepGtgJGwq5MRrt4b0 ARboxp2s8SGXLg5ZGxY7lIQUxMnsFpjxDj7aw9jII6MXNxTXpcpcNSMnc7asz+ZL4J413Eg xQGvDgVgJw1NIAv0oGrfA== X-UI-Out-Filterresults: notjunk:1;V03:K0:dkUaghogZJM=:fgkZdwjbvnrIqyBPzeiSjz HgyTO2hBQvZUfzDHe0ED0kRf29FVprwbJ+XQldh07PFTsN0RqDuCjgCo1FUE+QtRJGp2i6n5X IfOxc7KIsfR/p0TQRrH/o2lkVhBkOpv83bvmlYH8Dnv1/2KCY+AxSwKLJripbyw4bV4TngiJ9 js2eoF+AIjwXUY/ejgxxOCImjbiJYlvWYTNyqJKZA+67HAhLT6y/XhJX68WPlvO7J0ziWT2c/ GY4GFSRkE1F3UOwM7a4F4BBJfoDQ6gZKShnS5giCnc7NWi8HcCE8LNoR5aNgPjT8ukGJvMJ5t oeMROoKazKBAOt9RgG83o36eyOz7MPwce+0iNiI5b72IuBymTeF4xzmI4dUBRz9pzhAkCVG0Q gtPKLLZJ8NjzhK2tYh7n4c2MFfpneLQU/a3+ZTbNmvPvjLrPJh9gY+L2MtLZAqpfWb0v+TJ8P TWQHgkrpCeFI+CAAf/8VY2BDOS5y5X54Eq4TSes8EGL3oa9UcZK++JljegvmwsG+MU9YHmryc kpwo1tpr3cLlyq4yaVvXejqkLflaa3RxPnQ+YOdCTSj/LIjg6bHJlyqVkZUg57Zb/3fDK3VEi 2VTLfZXkXrghn1yZMqRldSxZvGmgnTd/si6VCaW2XdOr18r3viGDZljrxjH4rbU21ZC8dOhhe e8EVzHP3IBTp83K4KUdLbDMfBUQk9Oy+W4YUXa7oD3ZetaKb18XtFUSQ7jFtYyiywfAR7e+DH YArJPNioFggKGweNy2pEOKt6JHchOXIaFl6gboG0u6xMo4sUTnGYyDA+d76QvYAGaW+7s78I6 1uAIERe1JuJYDM+n2mDgFReBi/Wx7oWd1vAoVtKAK7bj9K8UoA= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 6, 2022 at 3:09 AM Philip Li wrote: > On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > > On 5/3/22 00:21, Arnd Bergmann wrote: > > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > >> From: kernel test robot > > >> > > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > >> > > >> Remove unneeded variable used to store return value. > > >> > > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > > >> > > >> Reported-by: kernel test robot > > >> Signed-off-by: kernel test robot > > > I checked the patch, and unfortunately it is wrong, the current code > > > needs to stay. > > > The problem is the SET_DMA_ERRATA() macro that accesses the > > > local 'errata' variable. > > > > 0day folks, do we have humans looking over these before they're going > > out to the list? If not, can we add some? If so, can the humans get a > > little more discerning? ;) > > Sorry all for the bad patch. So far, we pick up several cocci warnings that > we have confidence based on early result analysis and feedback, for these > warnings, 0day sends out patch automatically. > > Thanks for the suggestion Dave, We will change current process to be more > conservative and to avoid false patch by adding human analysis. For the returnvar.cocci false-positives, I wonder if it's possible to find them using another coccinelle helper that detects badly formed macros which access variables out of scope. I can't think of how this would be expressed, but maybe someone has an idea. Something else went wrong in this particular patch, and I can't explain how this happened: the subject line contains the name of the wrong platform, "dove" rather than "omap2". My guess is that this was human error copying the subject line from another patch, but if this came from a script, you may want to check how this gets generated. Arnd