From: Arnd Bergmann <arnd@arndb.de>
To: Yury Norov <yury.norov@gmail.com>
Cc: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] linux/bits.h: Fix compilation error with GENMASK
Date: Thu, 20 May 2021 22:15:02 +0200 [thread overview]
Message-ID: <CAK8P3a1i1XE_rUrg_kX87NPA7NBJa5m2gVrHSuBE3XzFLUKPWA@mail.gmail.com> (raw)
In-Reply-To: <YKa8JjT9AFOspIl5@yury-ThinkPad>
On Thu, May 20, 2021 at 9:44 PM Yury Norov <yury.norov@gmail.com> wrote:
> On Thu, May 20, 2021 at 08:46:40PM +0200, Rikard Falkeborn wrote:
> > > > +/*
> > > > + * This returns a constant expression while determining if an argument is
> > > > + * a constant expression, most importantly without evaluating the argument.
> > > > + * Glory to Martin Uecker <Martin.Uecker@med.uni-goettingen.de>
> > > > + */
> > > > +#define __is_constexpr(x) \
> > > > + (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
> > > > +
> > > > #endif /* _LINUX_CONST_H */
> > > > --
> > > > 2.31.1
> > > >
> >
> > Friendly ping.
>
> I added this patch in my Bitmap tree, but since it's actually a build
> bug fix, I think it's worth to move it faster with Arnd's or Andrew's
> trees?
I have a few days off next week and won't be able to validate it before then,
so it would be faster to have Andrew pick it up.
Moving the definition to const.h seem reasonable to me here, feel
free to add
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2021-05-20 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 20:37 [PATCH] linux/bits.h: Fix compilation error with GENMASK Rikard Falkeborn
2021-05-12 12:53 ` Ard Biesheuvel
2021-05-20 18:46 ` Rikard Falkeborn
2021-05-20 19:44 ` Yury Norov
2021-05-20 20:15 ` Arnd Bergmann [this message]
2021-05-20 20:41 ` Andrew Morton
2021-05-21 11:59 ` Andy Shevchenko
2021-05-21 10:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1i1XE_rUrg_kX87NPA7NBJa5m2gVrHSuBE3XzFLUKPWA@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=rikard.falkeborn@gmail.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).