From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB9F1C433EF for ; Fri, 29 Oct 2021 12:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B184961167 for ; Fri, 29 Oct 2021 12:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231530AbhJ2MJS (ORCPT ); Fri, 29 Oct 2021 08:09:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:33442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231510AbhJ2MJR (ORCPT ); Fri, 29 Oct 2021 08:09:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99B5261167 for ; Fri, 29 Oct 2021 12:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635509208; bh=wHSN4gzbMNlP3cL0uOMD0Bz+CpMAiXAmVJsjYeOYTuY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=BqxXoqRchGkK6bbVqSvH6vrUMYS6QQNRuZLuHTaEwKjyesVVYW0M1R9xUyPPVBq/b Fdea7iZFhFgpqUeLPEnikp4auVRHTVZ6HsBgNJ9tVCXmRGjBtpowc5ra9WHKtd8yMs YnSeEwUk5p5XqZDY6LHNj4zVsV6VygKxVbIpTAFlPdDKR+iVPJo7M5gihmWgTLWa3m RwjDuf8KYntAKGwcMzWzt+36lC0HDhifSLL4qM84mnFq2EAb1YzMwcR3ltwpvOdGKG B9FDoUGyoMzoK9qogHhyPDZxWwb84e+trtmAoNNXN3M5Ajp+uRaiZXKT5tELtyfD5t mplXexvNHCfhA== Received: by mail-wr1-f54.google.com with SMTP id k7so15767425wrd.13 for ; Fri, 29 Oct 2021 05:06:48 -0700 (PDT) X-Gm-Message-State: AOAM5335fG3RA336gOYWcZbi/Qkm5usyg3DIM6/Qq4SGNVs7pUuaOiPj +dYi+uWC6X75IyooMjnvDwZlzcOJS6VA6adeRJQ= X-Google-Smtp-Source: ABdhPJyuj/QVAPGVv6P9H50bSyp8g+Y5gAbxa7PrEH9Io/M+TBSmkz99ozucgwXHa/I3Q6KEGbXDDmRLxgKXyg6skhU= X-Received: by 2002:adf:e292:: with SMTP id v18mr13328237wri.369.1635509207143; Fri, 29 Oct 2021 05:06:47 -0700 (PDT) MIME-Version: 1.0 References: <20210927142816.2069269-1-arnd@kernel.org> <202109270923.97AFDE89DB@keescook> <878ryeit9i.fsf@intel.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 29 Oct 2021 14:06:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency To: Javier Martinez Canillas , Arnd Bergmann , Jani Nikula , Kees Cook , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Arnd Bergmann , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel , Linux Kernel Mailing List Cc: Daniel Vetter Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 5:24 PM Daniel Vetter wrote: > > On Wed, Oct 27, 2021 at 03:19:34PM +0200, Javier Martinez Canillas wrote: > > On 10/27/21 14:18, Arnd Bergmann wrote: > > > > [snip] > > > > > Right, how about this change on top? > > > > > > --- a/drivers/gpu/drm/Kconfig > > > +++ b/drivers/gpu/drm/Kconfig > > > @@ -117,9 +117,8 @@ config DRM_DEBUG_MODESET_LOCK > > > > > > config DRM_FBDEV_EMULATION > > > bool "Enable legacy fbdev support for your modesetting driver" > > > - depends on DRM > > > - depends on FB=y || FB=DRM > > > - select DRM_KMS_HELPER > > > + depends on DRM_KMS_HELPER > > > + depends on FB=y || FB=DRM_KMS_HELPER > > > select FB_CFB_FILLRECT > > > select FB_CFB_COPYAREA > > > select FB_CFB_IMAGEBLIT > > > > > > That would probably make it work for DRM=y, FB=m, DRM_KMS_HELPER=m, > > > but it needs more randconfig testing, which I can help with. > > > > Looks good to me as well. > > > > Reviewed-by: Javier Martinez Canillas > > Is the mess I created sorted now, or something for me to do? I'm terribly > burried in stuff :-/ I have done a few days worth of build testing with that patch applied, and did not see any other problems. I've written a proper description and submitted it as https://lore.kernel.org/all/20211029120307.1407047-1-arnd@kernel.org/T The version you have in linux-next works correctly, but this patch on top is an improvement. Arnd