From: Arnd Bergmann <arnd@arndb.de>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
linux-rtc@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Stephen Boyd <sboyd@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH v8 3/4] clocksource/drivers: Add a goldfish-timer clocksource
Date: Sun, 16 Jan 2022 17:19:43 +0100 [thread overview]
Message-ID: <CAK8P3a1i_ngEaqhsy4xNrQV8=d1jY=JTxGNNUqOZ0g0to5bw8Q@mail.gmail.com> (raw)
In-Reply-To: <77e747de-c7d6-314d-e0b0-58852d463326@vivier.eu>
On Sun, Jan 16, 2022 at 12:54 PM Laurent Vivier <laurent@vivier.eu> wrote:
>
> Virtio has exactly the same problem in the past (prio to v1.0), and it uses __LITTLE_ENDIAN in
> virtio_legacy_is_little_endian() to know the endianness of the device.
Right, that was my point, let's not duplicate the bug from pre-standard virtio.
> So the code can become:
>
> #ifdef __LITTLE_ENDIAN
> #define goldfish_ioread32 ioread32
> #define goldfish_iowrite32 iowrite32
> #else
> #define goldfish_ioread32 ioread32be
> #define goldfish_iowrite32 iowrite32be
> #endif
This is exactly the same as what you had before, it continues to break when
host and guest disagree on the endianess.
> What do you prefer: CONFIG_M68K or __LITTLE_ENDIAN?
Checking for CONFIG_M68K at least has a chance of working, provided
that all existing qemu implementations agree on the semantics here.
Arnd
next prev parent reply other threads:[~2022-01-16 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 19:32 [PATCH v8 0/4] m68k: Add Virtual M68k Machine Laurent Vivier
2022-01-15 19:32 ` [PATCH v8 1/4] m68k: add asm/config.h Laurent Vivier
2022-01-15 19:32 ` [PATCH v8 2/4] rtc: goldfish: introduce goldfish_ioread32()/goldfish_iowrite32() Laurent Vivier
2022-01-15 22:25 ` Jiaxun Yang
2022-01-15 19:32 ` [PATCH v8 3/4] clocksource/drivers: Add a goldfish-timer clocksource Laurent Vivier
2022-01-16 10:44 ` Arnd Bergmann
2022-01-16 10:55 ` Laurent Vivier
2022-01-16 11:54 ` Laurent Vivier
2022-01-16 16:19 ` Arnd Bergmann [this message]
2022-01-15 19:32 ` [PATCH v8 4/4] m68k: introduce a virtual m68k machine Laurent Vivier
2022-01-15 19:41 ` Geert Uytterhoeven
2022-01-15 19:47 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1i_ngEaqhsy4xNrQV8=d1jY=JTxGNNUqOZ0g0to5bw8Q@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=daniel.lezcano@linaro.org \
--cc=geert@linux-m68k.org \
--cc=jiaxun.yang@flygoat.com \
--cc=john.stultz@linaro.org \
--cc=laurent@vivier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).