From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Christopher Li <sparse@chrisli.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
linux-sparse@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] compiler-gcc.h: __nostackprotector needs gcc-4.4 and up
Date: Thu, 1 Feb 2018 16:29:53 +0100 [thread overview]
Message-ID: <CAK8P3a1kW=c0p6wnNMu_85z4Rq1aRA02+mqRYkhnGTsuXsVjmw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWHZMxRg91LVz6n1GsM+6jezdzzfnDtBTXixHh=Updt5A@mail.gmail.com>
On Thu, Feb 1, 2018 at 12:55 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Arnd,
>
> On Thu, Feb 1, 2018 at 12:46 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Thu, Feb 1, 2018 at 11:21 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> Gcc versions before 4.4 do not recognize the __optimize__ compiler
>>> attribute:
>
> And we might want to remove the dummy in include/linux/compiler_types.h:
>
> #ifndef __nostackprotector
> # define __nostackprotector
> #endif
>
> BTW, how does this work with non-gcc compilers?
clang should in theory accept the same flags, and it pretends to be an older
version of gcc.
I don't think anyone cares about ICC or any other compiler.
Arnd
next prev parent reply other threads:[~2018-02-01 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 10:21 [PATCH 1/3] compiler-gcc.h: Introduce __optimize function attribute Geert Uytterhoeven
2018-02-01 10:21 ` [PATCH 2/3] compiler-gcc.h: __nostackprotector needs gcc-4.4 and up Geert Uytterhoeven
2018-02-01 11:46 ` Arnd Bergmann
2018-02-01 11:55 ` Geert Uytterhoeven
2018-02-01 15:29 ` Arnd Bergmann [this message]
2018-02-01 10:22 ` [PATCH 3/3] crypto: sha3-generic - Use __optimize to support old compilers Geert Uytterhoeven
2018-02-01 17:30 ` Ard Biesheuvel
2018-02-01 17:30 ` [PATCH 1/3] compiler-gcc.h: Introduce __optimize function attribute Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1kW=c0p6wnNMu_85z4Rq1aRA02+mqRYkhnGTsuXsVjmw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).