From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D090C3F6B0 for ; Tue, 9 Aug 2022 21:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbiHIVnD (ORCPT ); Tue, 9 Aug 2022 17:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbiHIVmv (ORCPT ); Tue, 9 Aug 2022 17:42:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4DD46AA13; Tue, 9 Aug 2022 14:42:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A5682B8136E; Tue, 9 Aug 2022 21:42:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75BBEC433C1; Tue, 9 Aug 2022 21:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660081368; bh=LWQCSC8FfjD55HWw0CaXRB1hieerDY6z05vJfxpHEHg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eyZONta/AY5NtbKKWqKeonHKFZeLmxIazytRuQI+Am+sNzdG/wHdAvER4mdnvk2/z nj0myWJfmcgwLwZyaP+ZAVFFoNHljht/kTGTAZj+5MxOxKMfwbmHWGEqzZ7gofaKNn x+fLNSNPwuhuVt7/8GrrNieBPiIKHmkTZ2UMjG8bijFA7idZsvgUG7g6B1192pwsTW gCjHi4o+63/2JlkI+/pN5pyc/b502yiSLbIwbmhgERytcc95geCoqAERexkZu7vmw3 axguioooj2XkvGSVfSrNRQi+qtBjgXzHrkDaPOGhcOzNvOeYoLv8Ako8+6vuR+j3RM UjN8N+P6FZXUw== Received: by mail-wm1-f43.google.com with SMTP id 186-20020a1c02c3000000b003a34ac64bdfso106999wmc.1; Tue, 09 Aug 2022 14:42:48 -0700 (PDT) X-Gm-Message-State: ACgBeo054Z5fiZSBfy9qlzoWuoXb63NBi/mEaAOS5az0WcO1Vi4PlLrk 7FdSv9G7SBXRHESNS94LVkbzfEqFM9n5h0eAuhA= X-Google-Smtp-Source: AA6agR46znHPnjXuMF0ESE8yshyOz9FwMBs5CzrB/1w3Ltrdqh36cdhHWvBCtR8W2w5FTqLo7Im4fOVR23KjCUL7o+g= X-Received: by 2002:a05:600c:1e8f:b0:3a4:e0f0:4bad with SMTP id be15-20020a05600c1e8f00b003a4e0f04badmr224990wmb.133.1660081366742; Tue, 09 Aug 2022 14:42:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Tue, 9 Aug 2022 23:42:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] asm-generic: Conditionally enable do_softirq_own_stack() via Kconfig. To: Sebastian Andrzej Siewior Cc: Linus Torvalds , Thomas Gleixner , linux-arch , Linux ARM , Linux Kernel Mailing List , Sai Prakash Ranjan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 9, 2022 at 5:57 PM Sebastian Andrzej Siewior wrote: > > Remove the CONFIG_PREEMPT_RT symbol from the ifdef around > do_softirq_own_stack() and move it to Kconfig instead. > > Enable softirq stacks based on SOFTIRQ_ON_OWN_STACK which depends on > HAVE_SOFTIRQ_ON_OWN_STACK and its default value is set to !PREEMPT_RT. > This ensures that softirq stacks are not used on PREEMPT_RT and avoids > a 'select' statement on an option which has a 'depends' statement. > > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/Kconfig | 4 ++++ > arch/arm/kernel/irq.c | 2 +- > arch/parisc/kernel/irq.c | 2 +- > arch/powerpc/kernel/irq.c | 4 ++-- > arch/s390/include/asm/softirq_stack.h | 2 +- > arch/sh/kernel/irq.c | 2 +- > arch/sparc/kernel/irq_64.c | 2 +- > arch/x86/include/asm/irq_stack.h | 2 +- > arch/x86/kernel/irq_32.c | 2 +- > include/asm-generic/softirq_stack.h | 2 +- Thanks for the patch, I assume Linus will want to pick this up himself. Let me know if I should give it a spin in the asm-generic tree first for additional build testing. Acked-by: Arnd Bergmann