From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50EA9C4338F for ; Thu, 5 Aug 2021 06:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 144C060EC0 for ; Thu, 5 Aug 2021 06:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235727AbhHEGvN (ORCPT ); Thu, 5 Aug 2021 02:51:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:57610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231418AbhHEGvM (ORCPT ); Thu, 5 Aug 2021 02:51:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D6B6960F41 for ; Thu, 5 Aug 2021 06:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628146258; bh=qMsPpqQgFUPSSPnZfZavNoLnNsZYb+hVgAtPZNQBy5w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ObhBf+NN4GqwQxNx/Lx+8AMAwuGlEvoXaj2dr50XEIYqzYy/HZE2xI7CL2r/XBdRm h7Jl0yGq7YppbC5Qi+io0LfpKg8+sqkjPa7VgkgDzQj7MZ8Za/g84FRPLsS/geIrib XeHHxL9J9xr5FwusDdEI8d630JA5vK4xwDEB/ag73EcJ8nyoA5iocv71E6axsMyg03 MQJsYEqpOGmzbPpV4barhyJ1DNTVMGbVfR76rJJ/glh7MLH4aQwApNRc3MqRkjAboQ UO7cggith/pKaisdmkMHzNieFdV7GQLpIG3V5j64ROArAcaNQjL0LWYWAPOA436KVE lr78sf0ffppPw== Received: by mail-wr1-f44.google.com with SMTP id p5so5076257wro.7 for ; Wed, 04 Aug 2021 23:50:58 -0700 (PDT) X-Gm-Message-State: AOAM533mvrVpQ8XuUCJ4BJBd/Iw/y7IjxVfgXHIWvO5iYprt+/3ORBEY /ZIuHUaHwTopmioowzJd4noLCE0apWHS7jqUGwA= X-Google-Smtp-Source: ABdhPJznMWhOISmuIYDXrWpGkt4y1m+fqzTgxmRqDkmkTEHJHsPKR7IHYLL2Gk1DFScHpZ5gzgXyDTyRE3rrOBfVhqs= X-Received: by 2002:adf:f7c5:: with SMTP id a5mr3290312wrq.99.1628146257464; Wed, 04 Aug 2021 23:50:57 -0700 (PDT) MIME-Version: 1.0 References: <20210804141049.499767-1-kherbst@redhat.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 5 Aug 2021 08:50:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices To: Karol Herbst Cc: Linux Kernel Mailing List , Lyude Paul , Ben Skeggs , Randy Dunlap , Daniel Vetter , ML nouveau , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 5, 2021 at 12:01 AM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > > > > > playing around a little bit with this, I think the original "select > > > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > > > drivers selecting and others depending on it. We could of course convert > > > > > > everything over to depend, and break those cycling dependency issues with > > > > > > this. > > > > > > > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > > > > happy and has the advantage of not having to mess with the deps of nouveau > > > > > > too much. > > > > > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > > > keep working. > > > > > > > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > > > > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > > > BACKLIGHT_CLASS_DEVICE might be disabled :( > > > > Are you sure? It should already be the case that any driver that selects > > FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' > > or 'select BACKLIGHT_CLASS_DEVICE'. > > > none of the fb drivers seem to do that. Ah, right, I see now that my randconfig series has a couple of patches applied that deal with other random failures, including this one: https://patchwork.kernel.org/project/linux-fbdev/patch/20200417155553.675905-8-arnd@arndb.de/ Part of the series went in (through different ways) now, but this one never did. Arnd