From: Arnd Bergmann <arnd@arndb.de>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Ben Skeggs <bskeggs@redhat.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
ML nouveau <nouveau@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE
Date: Fri, 8 May 2020 17:05:03 +0200 [thread overview]
Message-ID: <CAK8P3a1vCx=XibDdoDqG9obpCFx0JCibAvcKFh6E7_NR_hJ03A@mail.gmail.com> (raw)
In-Reply-To: <20200508150041.GI19158@mellanox.com>
On Fri, May 8, 2020 at 5:00 PM Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> On Fri, May 08, 2020 at 04:40:09PM +0200, Arnd Bergmann wrote:
> > CONFIG_DEVICE_PRIVATE cannot be selected in configurations
> > without ZONE_DEVICE:
>
> It is kind of unfortunate to lift dependencies from DEVICE_PRIVATE
> into the users, is this really how kconfig is supposed to work or is
> something else wrong here?
Usually the problem is trying to use 'select' for something that can
be done with 'depends on'. I have actually no idea what
CONFIG_DEVICE_PRIVATE does, as it lacks a help text
and is a rather generic term.
Would it be possible to decouple DEVICE_PRIVATE from ZONE_DEVICE?
It sounds like the first is related to the device model, while
the second is for memory management, so maybe the dependency
is not necessary.
Arnd
next prev parent reply other threads:[~2020-05-08 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 14:40 [PATCH 1/2] HMM: test: fix CONFIG_DEVICE_PRIVATE dependencies Arnd Bergmann
2020-05-08 14:40 ` [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE Arnd Bergmann
2020-05-08 15:00 ` Jason Gunthorpe
2020-05-08 15:05 ` Arnd Bergmann [this message]
2020-05-08 19:04 ` Jason Gunthorpe
2020-05-08 20:39 ` Arnd Bergmann
2020-05-08 18:05 ` Randy Dunlap
2020-05-11 13:52 ` Jason Gunthorpe
2020-05-08 17:00 ` [PATCH 1/2] HMM: test: fix CONFIG_DEVICE_PRIVATE dependencies Ralph Campbell
2020-05-08 18:05 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1vCx=XibDdoDqG9obpCFx0JCibAvcKFh6E7_NR_hJ03A@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jgg@mellanox.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).