From: Arnd Bergmann <arnd@arndb.de>
To: Orson Zhai <orson.zhai@unisoc.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
DTML <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kevin.tang@unisoc.com, baolin.wang@unisoc.com,
Chunyan Zhang <chunyan.zhang@unisoc.com>
Subject: Re: [PATCH V2 1/2] dt-bindings: syscon: Add syscon-names to refer to syscon easily
Date: Thu, 21 Nov 2019 15:59:34 +0100 [thread overview]
Message-ID: <CAK8P3a1vuPWZYpMB9OGdLaCmbC6A0+5ecjKmdMqFUjpPmwp+tg@mail.gmail.com> (raw)
In-Reply-To: <20191120154148.22067-2-orson.zhai@unisoc.com>
On Wed, Nov 20, 2019 at 4:44 PM Orson Zhai <orson.zhai@unisoc.com> wrote:
>
> +
> +Optional property:
> +- #.*-cells: Represents the number of arguments in single phandle in syscons
> + list. ".*" is vendor specific. If this property is not set, default value
> + will be 0.
> +
> +Examples:
> +
> +apb_regs: syscon@20008000 {
> + compatible = "sprd,apb-glb", "syscon";
> + reg = <0x20008000 0x100>;
> +};
> +
> +aon_regs: syscon@40008000 {
> + compatible = "sprd,aon-glb", "syscon";
> + reg = <0x40008000 0x100>;
> +};
> +
> +display@40500000 {
> + ...
> + #syscon-disp-cells = <2>;
> + syscons = <&ap_apb_regs 0x4 0xf00>, <&aon_regs 0x8 0x7>;
> + syscon-names = "enable", "power";
> +};
Hi Orson,
With the changes from the syscon nodes removed, it looks better
already, but I'd also like to not see the #.*-cells mentioned at
all, as there is not really a way to parse this automatically, or
make sense of the data without already knowing how many cells
there are.
Arnd
next prev parent reply other threads:[~2019-11-21 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 15:41 [PATCH V2 0/2] Add syscon name support Orson Zhai
2019-11-20 15:41 ` [PATCH V2 1/2] dt-bindings: syscon: Add syscon-names to refer to syscon easily Orson Zhai
2019-11-21 14:59 ` Arnd Bergmann [this message]
2019-12-04 16:38 ` Rob Herring
2019-12-04 17:00 ` Arnd Bergmann
2019-12-04 19:26 ` Rob Herring
2019-12-05 9:20 ` Arnd Bergmann
2019-12-05 12:55 ` Orson Zhai
2019-12-05 15:12 ` Rob Herring
[not found] ` <CA+H2tpEZ_d-c6DcfQ3yZPf4s_0GTe-q5q4FnVydYm2cdi0im=g@mail.gmail.com>
2019-12-05 16:55 ` Orson Zhai
2019-11-20 15:41 ` [PATCH V2 2/2] mfd: syscon: Find syscon by names with arguments support Orson Zhai
2019-11-21 15:04 ` Arnd Bergmann
2019-11-22 16:21 ` Orson Zhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1vuPWZYpMB9OGdLaCmbC6A0+5ecjKmdMqFUjpPmwp+tg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=baolin.wang@unisoc.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=kevin.tang@unisoc.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orson.zhai@unisoc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).